Enable bench for 9.10 (#4512)

* Update cabal.project and shake-bench.cabal: remove obsolete flags and add source repository

* cabal.project: Add comment regarding specific hp2pretty version due to bug

* workflow: Update performance label condition for bench job skipping

* workflow: Adjust bench job conditions for performance label handling

* workflow: Update GitHub Actions to use latest versions of actions and GHC

* Replace hp2pretty with eventlog2html in benchmark dependencies and heap profile rules

* cabal.project: Remove hp2pretty source repository due to bug resolution

* cabal.project: Remove unnecessary newline in constraints section

* workflow: Downgrade download-artifact action to v3 for compatibility

* workflow: Upgrade download-artifact action to v4 for improved functionality

* workflow: Update GHC version matrix to include 9.10

Author: soulomoon

.github/workflows/bench.yml

@@ -17,7 +17,6 @@ on:
 jobs:
   pre_job:
     runs-on: ubuntu-latest
-    if: contains(github.event.pull_request.labels.*.name, 'performance')
     outputs:
       should_skip: ${{ steps.skip_check.outputs.should_skip }}
     steps:
@@ -53,16 +52,16 @@ jobs:
         # see discussion https://github.com/haskell/haskell-language-server/pull/4118
         # also possible to add more GHCs if we performs better in the future.
         ghc:
-          - '9.6'
           - '9.8'
+          - '9.10'
         os:
           - ubuntu-latest
 
     # This code is fitted to the strategy: assumes Linux is used ... etc,
     # change of the strategy may require changing the bootstrapping/run code
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
       with:
 
         # By default, the `pull_request` event has a `GITHUB_SHA` env variable
@@ -101,27 +100,28 @@ jobs:
         tar -czf cabal.tar.gz *
 
     - name: Upload workspace
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: workspace-${{ matrix.ghc }}-${{ matrix.os }}
         retention-days: 1
         path: workspace.tar.gz
 
     - name: Upload .cabal
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: cabal-home-${{ matrix.ghc }}-${{ matrix.os }}
         retention-days: 1
         path: ~/.cabal/cabal.tar.gz
 
   bench_example:
+    if: contains(github.event.pull_request.labels.*.name, 'performance')
     needs: [bench_init, pre_job]
     runs-on: ${{ matrix.os }}
 
     strategy:
       fail-fast: false
       matrix:
-        ghc: ['9.6', '9.8']
+        ghc: ['9.8', '9.10']
         os: [ubuntu-latest]
         cabal: ['3.10']
         example: ['cabal', 'lsp-types']
@@ -134,13 +134,13 @@ jobs:
         enable-stack: false
 
     - name: Download cabal home
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: cabal-home-${{ matrix.ghc }}-${{ matrix.os }}
         path: .
 
     - name: Download workspace
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: workspace-${{ matrix.ghc }}-${{ matrix.os }}
         path: .
@@ -165,7 +165,7 @@ jobs:
       run:  find bench-results -name "*.csv" -or -name "*.svg" -or -name "*.html" | xargs tar -czf benchmark-artifacts.tar.gz
 
     - name: Archive benchmarking artifacts
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: bench-results-${{ matrix.example }}-${{ runner.os }}-${{ matrix.ghc }}
         path: benchmark-artifacts.tar.gz
@@ -175,7 +175,7 @@ jobs:
       run: find bench-results -name "*.log" -or -name "*.hp" | xargs tar -czf benchmark-logs.tar.gz
 
     - name: Archive benchmark logs
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: bench-logs-${{ matrix.example }}-${{ runner.os }}-${{ matrix.ghc }}
         path: benchmark-logs.tar.gz

cabal.project

@@ -49,9 +49,6 @@ constraints:
   -- in the future, thus: TODO: remove this flag.
   bitvec -simd,
 
-if impl(ghc >= 9.9)
-  -- https://github.com/haskell/haskell-language-server/issues/4324
-  benchmarks: False
 
 if impl(ghc >= 9.8.4) && impl(ghc < 9.8.5)
   -- By depending on ghc-lib-parser and ghc, we are encountering

haskell-language-server.cabal

@@ -2100,7 +2100,7 @@ benchmark benchmark
     hs-source-dirs: bench
     build-tool-depends:
         haskell-language-server:ghcide-bench,
-        hp2pretty:hp2pretty,
+        eventlog2html:eventlog2html,
     default-extensions:
         LambdaCase
         RecordWildCards

shake-bench/shake-bench.cabal

@@ -16,8 +16,6 @@ source-repository head
     location: https://github.com/haskell/haskell-language-server.git
 
 library
-  if impl(ghc >= 9.10)
-    buildable: False
   exposed-modules:  Development.Benchmark.Rules
   hs-source-dirs:   src
   build-depends:

shake-bench/src/Development/Benchmark/Rules.hs

@@ -535,7 +535,7 @@ heapProfileRules build = do
     build -/- "*/*/*/*/*.heap.svg" %> \out -> do
       let hpFile = dropExtension2 out <.> "hp"
       need [hpFile]
-      cmd_ ("hp2pretty" :: String) [hpFile]
+      cmd_ ("eventlog2html" :: String) ["--heap-profile", hpFile]
       liftIO $ renameFile (dropExtension hpFile <.> "svg") out
 
 dropExtension2 :: FilePath -> FilePath