fix: removes open package and rolls open-in-browser util

Author: sunshastry

package-lock.json

@@ -52,12 +52,11 @@
     "@oclif/plugin-update": "^4.7.14",
     "@oclif/table": "^0.5.1",
     "date-fns": "^4.1.0",
-    "ora": "^9.0.0",
     "graphql": "^16.11.0",
     "inquirer": "^12.11.0",
     "keytar": "^7.9.0",
     "node-machine-id": "^1.1.12",
-    "open": "^10.2.0",
+    "ora": "^9.0.0",
     "packageurl-js": "^2.0.1",
     "terminal-link": "^5.0.0",
     "update-notifier": "^7.3.1"
@@ -123,4 +122,4 @@
     }
   },
   "types": "dist/index.d.ts"
-}
+}

package.json

@@ -3,10 +3,10 @@ import http from 'node:http';
 import { URL } from 'node:url';
 import { Command } from '@oclif/core';
 import inquirer from 'inquirer';
-import open from 'open';
 import { persistTokenResponse } from '../../service/auth.svc.ts';
 import { getClientId, getRealmUrl } from '../../service/auth-config.svc.ts';
 import type { TokenResponse } from '../../types/auth.ts';
+import { openInBrowser } from '../../utils/open-in-browser.ts';
 
 export default class AuthLogin extends Command {
   static description = 'OAuth CLI login';
@@ -94,7 +94,7 @@ export default class AuthLogin extends Command {
         });
 
         try {
-          await open(authUrl);
+          await openInBrowser(authUrl);
         } catch (err) {
           this.warn(
             `Failed to open browser automatically. Please open this URL manually:\n${authUrl}\n${err instanceof Error ? err.message : err}`,

src/commands/auth/login.ts

@@ -0,0 +1,21 @@
+import { exec } from "node:child_process";
+import { platform } from "node:os";
+
+export function openInBrowser(url: string): Promise<void> {
+  return new Promise((resolve, reject) => {
+    const escapedUrl = `"${url.replace(/"/g, '\\"')}"`;
+
+    const command = (() => {
+      const plat = platform();
+
+      if (plat === "darwin") return `open ${escapedUrl}`;            // macOS
+      if (plat === "win32") return `start "" ${escapedUrl}`;         // Windows
+      return `xdg-open ${escapedUrl}`;                               // Linux
+    })();
+
+    exec(command, (err) => {
+      if (err) reject(new Error(`Failed to open browser: ${err.message}`));
+      else resolve();
+    });
+  });
+}

src/utils/open-in-browser.ts

@@ -1,11 +1,9 @@
-import type { ChildProcess } from 'node:child_process';
-
 import type { Config } from '@oclif/core';
 import inquirer from 'inquirer';
-import open from 'open';
 import { type Mock, type MockedFunction, vi } from 'vitest';
 import AuthLogin from '../../../src/commands/auth/login.ts';
 import { persistTokenResponse } from '../../../src/service/auth.svc.ts';
+import { openInBrowser } from '../../../src/utils/open-in-browser.ts';
 
 type ServerRequest = { url?: string };
 type ServerResponse = { writeHead: Mock; end: Mock };
@@ -72,9 +70,9 @@ vi.mock('http', () => ({
   },
 }));
 
-vi.mock('open', () => ({
+vi.mock('../../../src/utils/open-in-browser.ts', () => ({
   __esModule: true,
-  default: vi.fn(),
+  openInBrowser: vi.fn(),
 }));
 
 vi.mock('inquirer', () => ({
@@ -89,7 +87,7 @@ vi.mock('../../../src/service/auth.svc.ts', () => ({
   persistTokenResponse: vi.fn().mockResolvedValue(undefined),
 }));
 
-const openMock = vi.mocked(open) as MockedFunction<typeof open>;
+const openMock = vi.mocked(openInBrowser) as MockedFunction<typeof openInBrowser>;
 const promptMock = vi.mocked(inquirer.prompt) as MockedFunction<typeof inquirer.prompt>;
 const persistTokenResponseMock = vi.mocked(persistTokenResponse);
 
@@ -126,7 +124,7 @@ const createCommand = (port: number) => {
 describe('AuthLogin', () => {
   beforeEach(() => {
     promptMock.mockResolvedValue({ confirm: true });
-    openMock.mockResolvedValue({} as ChildProcess);
+    openMock.mockResolvedValue(undefined);
   });
 
   afterEach(() => {

test/commands/auth/login.test.ts

@@ -0,0 +1,59 @@
+import type { ExecException } from 'node:child_process';
+
+import { beforeEach, describe, expect, it, vi } from 'vitest';
+
+const execMock = vi.fn<[string, ((err: ExecException | null) => void)?], void>();
+const platformMock = vi.fn<[], NodeJS.Platform>();
+
+vi.mock('node:child_process', () => ({
+  exec: execMock,
+}));
+
+vi.mock('node:os', () => ({
+  platform: platformMock,
+}));
+
+describe('openInBrowser', () => {
+  let openInBrowser: (url: string) => Promise<void>;
+
+  beforeEach(async () => {
+    execMock.mockReset();
+    platformMock.mockReset();
+    vi.resetModules();
+    ({ openInBrowser } = await import('../../src/utils/open-in-browser.ts'));
+  });
+
+  it('uses macOS open command when platform is darwin', async () => {
+    platformMock.mockReturnValue('darwin');
+    execMock.mockImplementation((_cmd, cb) => cb?.(null));
+
+    await expect(openInBrowser('https://example.com')).resolves.toBeUndefined();
+
+    expect(execMock).toHaveBeenCalledWith('open "https://example.com"', expect.any(Function));
+  });
+
+  it('uses Windows start command when platform is win32', async () => {
+    platformMock.mockReturnValue('win32');
+    execMock.mockImplementation((_cmd, cb) => cb?.(null));
+
+    await expect(openInBrowser('https://example.com')).resolves.toBeUndefined();
+
+    expect(execMock).toHaveBeenCalledWith('start "" "https://example.com"', expect.any(Function));
+  });
+
+  it('falls back to xdg-open on other platforms', async () => {
+    platformMock.mockReturnValue('linux');
+    execMock.mockImplementation((_cmd, cb) => cb?.(null));
+
+    await expect(openInBrowser('https://example.com')).resolves.toBeUndefined();
+
+    expect(execMock).toHaveBeenCalledWith('xdg-open "https://example.com"', expect.any(Function));
+  });
+
+  it('rejects when the underlying command fails', async () => {
+    platformMock.mockReturnValue('darwin');
+    execMock.mockImplementation((_cmd, cb) => cb?.(new Error('boom')));
+
+    await expect(openInBrowser('https://example.com')).rejects.toThrow('Failed to open browser: boom');
+  });
+});