HHH-18871 make use of explicitSqlAliasBase when creating table group

Author: robwgreenjr

hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/PluralAttributeMappingImpl.java

@@ -807,7 +807,6 @@ private TableGroup createRootTableGroupJoin(
 			SqlAstCreationState creationState) {
 		final CollectionPersister collectionDescriptor = getCollectionDescriptor();
 		final SqlAstJoinType joinType = determineSqlJoinType( lhs, requestedJoinType, fetched );
-		final SqlAliasBase sqlAliasBase = creationState.getSqlAliasBaseGenerator().createSqlAliasBase( getSqlAliasStem() );
 
 		final TableGroup tableGroup;
 		if ( collectionDescriptor.isOneToMany() ) {
@@ -818,7 +817,7 @@ private TableGroup createRootTableGroupJoin(
 					fetched,
 					addsPredicate,
 					explicitSourceAlias,
-					sqlAliasBase,
+					explicitSqlAliasBase,
 					creationState
 			);
 		}
@@ -830,7 +829,7 @@ private TableGroup createRootTableGroupJoin(
 					fetched,
 					addsPredicate,
 					explicitSourceAlias,
-					sqlAliasBase,
+					explicitSqlAliasBase,
 					creationState
 			);
 		}

hibernate-core/src/test/java/org/hibernate/orm/test/query/NativeQueryNestedTree.java

@@ -49,6 +49,43 @@ public void test(SessionFactoryScope scope) {
 					.list()
 			)
 		);
+
+		assertDoesNotThrow(() ->
+			scope.inTransaction(session ->
+				session.createNativeQuery("""
+						SELECT {t.*}, {t2.*}, {t3.*}, {t4.*}
+						FROM tree t
+						INNER JOIN tree t2 ON t2.parentident = t.ident
+						INNER JOIN tree t3 ON t3.parentident = t2.ident
+						INNER JOIN tree t4 ON t4.parentident = t3.ident
+					""")
+					.addEntity("t", TreeNode.class)
+					.addJoin("t2", "t.children")
+					.addJoin("t3", "t2.children")
+					.addJoin("t4", "t3.children")
+					.list()
+			)
+		);
+
+		// Let's get crazy
+		assertDoesNotThrow(() ->
+			scope.inTransaction(session ->
+				session.createNativeQuery("""
+						SELECT {t.*}, {t2.*}, {t3.*}, {t4.*}, {t5.*}
+						FROM tree t
+						INNER JOIN tree t2 ON t2.parentident = t.ident
+						INNER JOIN tree t3 ON t3.parentident = t2.ident
+						INNER JOIN tree t4 ON t4.parentident = t3.ident
+						INNER JOIN tree t5 ON t5.parentident = t4.ident
+					""")
+					.addEntity("t", TreeNode.class)
+					.addJoin("t2", "t.children")
+					.addJoin("t3", "t2.children")
+					.addJoin("t4", "t3.children")
+					.addJoin("t5", "t4.children")
+					.list()
+			)
+		);
 	}
 
 	@Entity(name = "TreeNode")