Skip to content

Commit d8b3ff9

Browse files
committed
Removed unnecessary "new" in Chart.to_js_literal(). Closes #42.
1 parent c0aff8b commit d8b3ff9

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

CHANGES.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
Release 1.1.1
2+
=========================================
3+
4+
* **FIXED:** Problem when producing a JS literal, with the JS code inserting an unnecessary ``new`` (#42 and #43).
5+
16
Release 1.1.0
27
=========================================
38

highcharts_core/__version__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '1.1.0'
1+
__version__ = '1.1.1'

highcharts_core/chart.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ def to_js_literal(self,
330330
callback_as_str = f"""{callback_as_str}"""
331331
signature_elements += 1
332332

333-
signature = """new Highcharts.chart("""
333+
signature = """Highcharts.chart("""
334334
signature += container_as_str
335335
if signature_elements > 1:
336336
signature += ',\n'

tests/input_files/chart_obj/01-expected.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
var someVariableName = new Highcharts.chart('some-div-id',
1+
var someVariableName = Highcharts.chart('some-div-id',
22
{
33
accessibility: {
44
announceNewData: {

0 commit comments

Comments
 (0)