Merge pull request #115 from PaulGiletich/annotation-sorting

hipstersmoothie · web-flow · commit 422745915bc4 · 2023-03-02T11:48:13.000-08:00
sort annotations by severity
diff --git a/src/create-check.ts b/src/create-check.ts
@@ -46,6 +46,12 @@ rxXIyGcdFUjpY/U2tobjXousbYyz8/DqgDoLWXOMt2dNkbbNAN8L3OMVTGb6TzS2
 gd8URXIGc6Nk7ueWMKEZaropIg6q1J7e9qJdlzA6j1fu6vVY3qX3tA==
 -----END RSA PRIVATE KEY-----`;
 
+const annotationsOrder: Record<Annotation['annotation_level'], number> = {
+  'failure': 1,
+  'warning': 2,
+  'notice': 3,
+}
+
 export async function createAnnotations(results: eslint.CLIEngine.LintResult[]) {
   const repoRoot = (await execa('git', ['rev-parse', '--show-toplevel'])).stdout;
 
@@ -73,7 +79,7 @@ export async function createAnnotations(results: eslint.CLIEngine.LintResult[])
     }
   }
 
-  return annotations;
+  return annotations.sort((a, b) => annotationsOrder[a.annotation_level] - annotationsOrder[b.annotation_level]);
 }
 
 export default async (results: eslint.CLIEngine.LintResult[]) => {

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,12 @@ rxXIyGcdFUjpY/U2tobjXousbYyz8/DqgDoLWXOMt2dNkbbNAN8L3OMVTGb6TzS2`
`46`	`46`	`gd8URXIGc6Nk7ueWMKEZaropIg6q1J7e9qJdlzA6j1fu6vVY3qX3tA==`
`47`	`47`	-----END RSA PRIVATE KEY-----`;
`48`	`48`
	`49`	`+const annotationsOrder: Record<Annotation['annotation_level'], number> = {`
	`50`	`+ 'failure': 1,`
	`51`	`+ 'warning': 2,`
	`52`	`+ 'notice': 3,`
	`53`	`+}`
	`54`	`+`
`49`	`55`	`export async function createAnnotations(results: eslint.CLIEngine.LintResult[]) {`
`50`	`56`	`const repoRoot = (await execa('git', ['rev-parse', '--show-toplevel'])).stdout;`
`51`	`57`
`@@ -73,7 +79,7 @@ export async function createAnnotations(results: eslint.CLIEngine.LintResult[])`
`73`	`79`	`}`
`74`	`80`	`}`
`75`	`81`
`76`		`- return annotations;`
	`82`	`+ return annotations.sort((a, b) => annotationsOrder[a.annotation_level] - annotationsOrder[b.annotation_level]);`
`77`	`83`	`}`
`78`	`84`
`79`	`85`	`export default async (results: eslint.CLIEngine.LintResult[]) => {`