3333 */
3434class Mqtt3ConnAckDecoderTest extends AbstractMqtt3DecoderTest {
3535
36- private static final @ NotNull byte [] WELLFORMED_CONNACK_BEGIN = {
36+ private static final byte @ NotNull [] WELLFORMED_CONNACK_BEGIN = {
3737 // type, flags
3838 0b0010_0000,
3939 //remaining length
4040 0b0000_0010
4141 };
42- private static final @ NotNull byte [] MALFORMED_CONNACK_BEGIN_WORNG_FLAGS = {
42+ private static final byte @ NotNull [] MALFORMED_CONNACK_BEGIN_WORNG_FLAGS = {
4343 // type, flags
4444 0b0010_0100,
4545 //remaining length
4646 0b0000_0010
4747 };
48- private static final @ NotNull byte [] MALFORMED_CONNACK_BEGIN_TOO_LONG_LENGTH = {
48+ private static final byte @ NotNull [] MALFORMED_CONNACK_BEGIN_TOO_LONG_LENGTH = {
4949 // type, flags
5050 0b0010_0100,
5151 //remaining length
5252 0b0000_0011
5353 };
54- private static final @ NotNull byte [] ENDING_TOO_LONG_MALFORMED = {0x01 };
55- private static final @ NotNull byte [] SESSION_PRESENT_TRUE = {0b0000_0001};
56- private static final @ NotNull byte [] SESSION_PRESENT_FALSE = {0b0000_0000};
57- private static final @ NotNull byte [] REASON_CODE_SUCCESS = {0x00 };
58- private static final @ NotNull byte [] REASON_CODE_UNACCEPTED_PROTOCOL_VERSION = {0x01 };
59- private static final @ NotNull byte [] REASON_CODE_IDENTIFIER_REJECTED = {0x02 };
60- private static final @ NotNull byte [] REASON_CODE_SERVER_UNAVAILABLE = {0x03 };
61- private static final @ NotNull byte [] REASON_CODE_SERVER_BAD_USERNAME_OR_PASSWORD = {0x04 };
62- private static final @ NotNull byte [] REASON_CODE_NOT_AUTHORIZED = {0x05 };
63- private static final @ NotNull byte [] REASON_CODE_BAD = {0x13 };
54+ private static final byte @ NotNull [] ENDING_TOO_LONG_MALFORMED = {0x01 };
55+ private static final byte @ NotNull [] SESSION_PRESENT_TRUE = {0b0000_0001};
56+ private static final byte @ NotNull [] SESSION_PRESENT_FALSE = {0b0000_0000};
57+ private static final byte @ NotNull [] REASON_CODE_SUCCESS = {0x00 };
58+ private static final byte @ NotNull [] REASON_CODE_UNACCEPTED_PROTOCOL_VERSION = {0x01 };
59+ private static final byte @ NotNull [] REASON_CODE_IDENTIFIER_REJECTED = {0x02 };
60+ private static final byte @ NotNull [] REASON_CODE_SERVER_UNAVAILABLE = {0x03 };
61+ private static final byte @ NotNull [] REASON_CODE_SERVER_BAD_USERNAME_OR_PASSWORD = {0x04 };
62+ private static final byte @ NotNull [] REASON_CODE_NOT_AUTHORIZED = {0x05 };
63+ private static final byte @ NotNull [] REASON_CODE_BAD = {0x13 };
6464
6565 Mqtt3ConnAckDecoderTest () {
6666 super (new MqttMessageDecoders () {{
@@ -71,9 +71,9 @@ class Mqtt3ConnAckDecoderTest extends AbstractMqtt3DecoderTest {
7171 @ ParameterizedTest
7272 @ ValueSource (strings = {"true" , "false" })
7373 void decode_SUCCESS (final boolean sessionPresent ) {
74- final byte [] encoded =
75- Bytes . concat ( WELLFORMED_CONNACK_BEGIN , sessionPresent ? SESSION_PRESENT_TRUE : SESSION_PRESENT_FALSE ,
76- REASON_CODE_SUCCESS );
74+ final byte [] encoded = Bytes . concat (
75+ WELLFORMED_CONNACK_BEGIN , sessionPresent ? SESSION_PRESENT_TRUE : SESSION_PRESENT_FALSE ,
76+ REASON_CODE_SUCCESS );
7777 final ByteBuf byteBuf = channel .alloc ().buffer ();
7878 byteBuf .writeBytes (encoded );
7979 channel .writeInbound (byteBuf );
@@ -86,9 +86,9 @@ void decode_SUCCESS(final boolean sessionPresent) {
8686 @ ParameterizedTest
8787 @ ValueSource (strings = {"true" , "false" })
8888 void decode_WRONG_PROTOCOL (final boolean sessionPresent ) {
89- final byte [] encoded =
90- Bytes . concat ( WELLFORMED_CONNACK_BEGIN , sessionPresent ? SESSION_PRESENT_TRUE : SESSION_PRESENT_FALSE ,
91- REASON_CODE_UNACCEPTED_PROTOCOL_VERSION );
89+ final byte [] encoded = Bytes . concat (
90+ WELLFORMED_CONNACK_BEGIN , sessionPresent ? SESSION_PRESENT_TRUE : SESSION_PRESENT_FALSE ,
91+ REASON_CODE_UNACCEPTED_PROTOCOL_VERSION );
9292 final ByteBuf byteBuf = channel .alloc ().buffer ();
9393 byteBuf .writeBytes (encoded );
9494 channel .writeInbound (byteBuf );
@@ -106,9 +106,9 @@ void decode_WRONG_PROTOCOL(final boolean sessionPresent) {
106106 @ ParameterizedTest
107107 @ ValueSource (strings = {"true" , "false" })
108108 void decode_SERVER_IDENTFIER_REJECTED (final boolean sessionPresent ) {
109- final byte [] encoded =
110- Bytes . concat ( WELLFORMED_CONNACK_BEGIN , sessionPresent ? SESSION_PRESENT_TRUE : SESSION_PRESENT_FALSE ,
111- REASON_CODE_IDENTIFIER_REJECTED );
109+ final byte [] encoded = Bytes . concat (
110+ WELLFORMED_CONNACK_BEGIN , sessionPresent ? SESSION_PRESENT_TRUE : SESSION_PRESENT_FALSE ,
111+ REASON_CODE_IDENTIFIER_REJECTED );
112112 final ByteBuf byteBuf = channel .alloc ().buffer ();
113113 byteBuf .writeBytes (encoded );
114114 channel .writeInbound (byteBuf );
@@ -126,9 +126,9 @@ void decode_SERVER_IDENTFIER_REJECTED(final boolean sessionPresent) {
126126 @ ParameterizedTest
127127 @ ValueSource (strings = {"true" , "false" })
128128 void decode_SERVER_UNAVAILABLE (final boolean sessionPresent ) {
129- final byte [] encoded =
130- Bytes . concat ( WELLFORMED_CONNACK_BEGIN , sessionPresent ? SESSION_PRESENT_TRUE : SESSION_PRESENT_FALSE ,
131- REASON_CODE_SERVER_UNAVAILABLE );
129+ final byte [] encoded = Bytes . concat (
130+ WELLFORMED_CONNACK_BEGIN , sessionPresent ? SESSION_PRESENT_TRUE : SESSION_PRESENT_FALSE ,
131+ REASON_CODE_SERVER_UNAVAILABLE );
132132 final ByteBuf byteBuf = channel .alloc ().buffer ();
133133 byteBuf .writeBytes (encoded );
134134 channel .writeInbound (byteBuf );
@@ -146,9 +146,9 @@ void decode_SERVER_UNAVAILABLE(final boolean sessionPresent) {
146146 @ ParameterizedTest
147147 @ ValueSource (strings = {"true" , "false" })
148148 void decode_SERVER_BAD_USERNAME_OR_PASSWORD (final boolean sessionPresent ) {
149- final byte [] encoded =
150- Bytes . concat ( WELLFORMED_CONNACK_BEGIN , sessionPresent ? SESSION_PRESENT_TRUE : SESSION_PRESENT_FALSE ,
151- REASON_CODE_SERVER_BAD_USERNAME_OR_PASSWORD );
149+ final byte [] encoded = Bytes . concat (
150+ WELLFORMED_CONNACK_BEGIN , sessionPresent ? SESSION_PRESENT_TRUE : SESSION_PRESENT_FALSE ,
151+ REASON_CODE_SERVER_BAD_USERNAME_OR_PASSWORD );
152152 final ByteBuf byteBuf = channel .alloc ().buffer ();
153153 byteBuf .writeBytes (encoded );
154154 channel .writeInbound (byteBuf );
@@ -166,9 +166,9 @@ void decode_SERVER_BAD_USERNAME_OR_PASSWORD(final boolean sessionPresent) {
166166 @ ParameterizedTest
167167 @ ValueSource (strings = {"true" , "false" })
168168 void decode_NOT_AUTHORIZED (final boolean sessionPresent ) {
169- final byte [] encoded =
170- Bytes . concat ( WELLFORMED_CONNACK_BEGIN , sessionPresent ? SESSION_PRESENT_TRUE : SESSION_PRESENT_FALSE ,
171- REASON_CODE_NOT_AUTHORIZED );
169+ final byte [] encoded = Bytes . concat (
170+ WELLFORMED_CONNACK_BEGIN , sessionPresent ? SESSION_PRESENT_TRUE : SESSION_PRESENT_FALSE ,
171+ REASON_CODE_NOT_AUTHORIZED );
172172 final ByteBuf byteBuf = channel .alloc ().buffer ();
173173 byteBuf .writeBytes (encoded );
174174 channel .writeInbound (byteBuf );
@@ -186,9 +186,9 @@ void decode_NOT_AUTHORIZED(final boolean sessionPresent) {
186186 @ ParameterizedTest
187187 @ ValueSource (strings = {"true" , "false" })
188188 void decode_BAD_RETURNCODE (final boolean sessionPresent ) {
189- final byte [] encoded =
190- Bytes . concat ( WELLFORMED_CONNACK_BEGIN , sessionPresent ? SESSION_PRESENT_TRUE : SESSION_PRESENT_FALSE ,
191- REASON_CODE_BAD );
189+ final byte [] encoded = Bytes . concat (
190+ WELLFORMED_CONNACK_BEGIN , sessionPresent ? SESSION_PRESENT_TRUE : SESSION_PRESENT_FALSE ,
191+ REASON_CODE_BAD );
192192 final ByteBuf byteBuf = channel .alloc ().buffer ();
193193 byteBuf .writeBytes (encoded );
194194 channel .writeInbound (byteBuf );
@@ -199,19 +199,13 @@ void decode_BAD_RETURNCODE(final boolean sessionPresent) {
199199 @ ParameterizedTest
200200 @ ValueSource (strings = {"1" , "2" })
201201 void decode_ERROR_CASES (final int errorcase ) throws Exception {
202- final byte [] encoded ;
203- switch (errorcase ) {
204- case 1 :
205- encoded = Bytes .concat (MALFORMED_CONNACK_BEGIN_WORNG_FLAGS , SESSION_PRESENT_FALSE , REASON_CODE_BAD );
206- break ;
207- case 2 :
208- encoded = Bytes .concat (MALFORMED_CONNACK_BEGIN_TOO_LONG_LENGTH , SESSION_PRESENT_FALSE , REASON_CODE_BAD ,
209- ENDING_TOO_LONG_MALFORMED );
210- break ;
211- default :
212- throw new Exception ();
213- }
214-
202+ final byte [] encoded = switch (errorcase ) {
203+ case 1 -> Bytes .concat (MALFORMED_CONNACK_BEGIN_WORNG_FLAGS , SESSION_PRESENT_FALSE , REASON_CODE_BAD );
204+ case 2 -> Bytes .concat (
205+ MALFORMED_CONNACK_BEGIN_TOO_LONG_LENGTH , SESSION_PRESENT_FALSE , REASON_CODE_BAD ,
206+ ENDING_TOO_LONG_MALFORMED );
207+ default -> throw new Exception ();
208+ };
215209 final ByteBuf byteBuf = channel .alloc ().buffer ();
216210 byteBuf .writeBytes (encoded );
217211 channel .writeInbound (byteBuf );
0 commit comments