Skip to content

Commit bacbf38

Browse files
authored
allow setting APN (#79)
1 parent e205937 commit bacbf38

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

Hologram/Network/Modem/BG96.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ def set_network_registration_status(self):
176176
def _set_up_pdp_context(self):
177177
if self._is_pdp_context_active(): return True
178178
self.logger.info('Setting up PDP context')
179-
self.set('+QICSGP', '1,1,\"hologram\",\"\",\"\",1')
179+
self.set('+QICSGP', f'1,1,\"{self._apn}\",\"\",\"\",1')
180180
ok, _ = self.set('+QIACT', '1', timeout=30)
181181
if ok != ModemResult.OK:
182182
self.logger.error('PDP Context setup failed')

Hologram/Network/Modem/Modem.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ def __init__(self, device_name=None, baud_rate='9600',
7474
self.result = ModemResult.OK
7575
self.debug_out = ''
7676
self.in_ext = False
77+
self._apn = 'hologram'
7778

7879
self._initialize_device_name(device_name)
7980

@@ -711,7 +712,7 @@ def _is_pdp_context_active(self):
711712
def _set_up_pdp_context(self):
712713
if self._is_pdp_context_active(): return True
713714
self.logger.info('Setting up PDP context')
714-
self.set('+UPSD', '0,1,\"hologram\"')
715+
self.set('+UPSD', f'0,1,\"{self._apn}\"')
715716
self.set('+UPSD', '0,7,\"0.0.0.0\"')
716717
ok, _ = self.set('+UPSDA', '0,3', timeout=30)
717718
if ok != ModemResult.OK:
@@ -913,11 +914,19 @@ def remoteIPAddress(self):
913914
else:
914915
return None
915916

916-
917917
@property
918918
def version(self):
919919
raise NotImplementedError('This modem does not support this property')
920920

921921
@property
922922
def imei(self):
923923
return self._basic_command('+GSN')
924+
925+
@property
926+
def apn(self):
927+
return self._apn
928+
929+
@apn.setter
930+
def apn(self, apn):
931+
self._apn = apn
932+
return self.set('+CGDCONT', f'1,"IP","{self._apn}"')

0 commit comments

Comments
 (0)