Skip to content
This repository was archived by the owner on Aug 22, 2024. It is now read-only.

Commit 391adec

Browse files
committed
[FIXED] Duplicate/similar code error below
https://codebeat.co/projects/github-com-amardeshbd-android-constraint-layout-cheatsheet-master/pull_requests/221367 ``` There is similar code in two places infomass = 150, difference = 2 app/src/main/java/com/hossainkhan/android/demo/layoutpreview/LayoutGuidelineBarrierActivity.kt companion object { /** * Creates an intent with required information to start this activity. * * @param context Activity context. */ fun createStartIntent(context: Context): Intent { val intent = Intent(context, LayoutGuidelineBarrierActivity::class.java) intent.putExtra(BUNDLE_KEY_LAYOUT_RESID, R.layout.preview_virtual_helper_barrier) return intent } } app/src/main/java/com/hossainkhan/android/demo/layoutpreview/LayoutChainStyleActivity.kt companion object { /** * Creates an intent with required information to start this activity. * * @param context Activity context. */ fun createStartIntent(context: Context): Intent { val intent = Intent(context, LayoutChainStyleActivity::class.java) intent.putExtra(BUNDLE_KEY_LAYOUT_RESID, R.layout.preview_chain_style_main) return intent } } ```
1 parent 39ed3c9 commit 391adec

File tree

5 files changed

+33
-55
lines changed

5 files changed

+33
-55
lines changed

app/src/main/java/com/hossainkhan/android/demo/browse/LayoutBrowseActivity.kt

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,13 +80,16 @@ class LayoutBrowseActivity : AppCompatActivity() {
8080

8181
when (layoutResId) {
8282
R.layout.preview_visibility_gone -> {
83-
startActivity(LayoutVisibilityGoneActivity.createStartIntent(this))
83+
startActivity(LayoutPreviewBaseActivity.createStartIntent(this,
84+
LayoutVisibilityGoneActivity::class.java, R.layout.preview_visibility_gone))
8485
}
8586
R.layout.preview_chain_style_main -> {
86-
startActivity(LayoutChainStyleActivity.createStartIntent(this))
87+
startActivity(LayoutPreviewBaseActivity.createStartIntent(this,
88+
LayoutChainStyleActivity::class.java, R.layout.preview_chain_style_main))
8789
}
8890
R.layout.preview_virtual_helper_barrier -> {
89-
startActivity(LayoutGuidelineBarrierActivity.createStartIntent(this))
91+
startActivity(LayoutPreviewBaseActivity.createStartIntent(this,
92+
LayoutGuidelineBarrierActivity::class.java, R.layout.preview_virtual_helper_barrier))
9093
}
9194
else -> {
9295
startActivity(LayoutPreviewBaseActivity.createStartIntent(this, layoutResId))

app/src/main/java/com/hossainkhan/android/demo/layoutpreview/LayoutChainStyleActivity.kt

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -16,20 +16,16 @@
1616

1717
package com.hossainkhan.android.demo.layoutpreview
1818

19-
import android.content.Context
20-
import android.content.Intent
2119
import android.os.Bundle
20+
import android.view.View
21+
import android.widget.RadioButton
22+
import android.widget.TextView
2223
import androidx.annotation.StringRes
2324
import androidx.constraintlayout.widget.ConstraintLayout
2425
import androidx.constraintlayout.widget.ConstraintSet
25-
import androidx.constraintlayout.widget.ConstraintSet.CHAIN_PACKED
26-
import androidx.constraintlayout.widget.ConstraintSet.CHAIN_SPREAD
27-
import androidx.constraintlayout.widget.ConstraintSet.CHAIN_SPREAD_INSIDE
26+
import androidx.constraintlayout.widget.ConstraintSet.*
2827
import androidx.transition.TransitionManager
29-
import android.view.View
3028
import com.hossainkhan.android.demo.R
31-
import android.widget.RadioButton
32-
import android.widget.TextView
3329
import timber.log.Timber
3430

3531
/**
@@ -39,19 +35,6 @@ import timber.log.Timber
3935
*/
4036
class LayoutChainStyleActivity : LayoutPreviewBaseActivity() {
4137

42-
companion object {
43-
/**
44-
* Creates an intent with required information to start this activity.
45-
*
46-
* @param context Activity context.
47-
*/
48-
fun createStartIntent(context: Context): Intent {
49-
val intent = Intent(context, LayoutChainStyleActivity::class.java)
50-
intent.putExtra(BUNDLE_KEY_LAYOUT_RESID, R.layout.preview_chain_style_main)
51-
return intent
52-
}
53-
}
54-
5538
private lateinit var constraintLayout: ConstraintLayout
5639
private lateinit var guideTextView: TextView
5740
/**

app/src/main/java/com/hossainkhan/android/demo/layoutpreview/LayoutGuidelineBarrierActivity.kt

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,28 +16,18 @@
1616

1717
package com.hossainkhan.android.demo.layoutpreview
1818

19-
import android.content.Context
20-
import android.content.Intent
2119
import android.os.Bundle
2220
import android.widget.Button
2321
import android.widget.TextView
2422
import com.hossainkhan.android.demo.R
2523

24+
/**
25+
* Activity showcasing how virtual guideline barrier changes when a view length changes within the barrier.
26+
*
27+
* See https://developer.android.com/reference/android/support/constraint/Barrier
28+
*/
2629
class LayoutGuidelineBarrierActivity : LayoutPreviewBaseActivity() {
2730

28-
companion object {
29-
/**
30-
* Creates an intent with required information to start this activity.
31-
*
32-
* @param context Activity context.
33-
*/
34-
fun createStartIntent(context: Context): Intent {
35-
val intent = Intent(context, LayoutGuidelineBarrierActivity::class.java)
36-
intent.putExtra(BUNDLE_KEY_LAYOUT_RESID, R.layout.preview_virtual_helper_barrier)
37-
return intent
38-
}
39-
}
40-
4131
override fun onCreate(savedInstanceState: Bundle?) {
4232
super.onCreate(savedInstanceState)
4333

app/src/main/java/com/hossainkhan/android/demo/layoutpreview/LayoutPreviewBaseActivity.kt

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,19 @@ open class LayoutPreviewBaseActivity : AppCompatActivity() {
6161
intent.putExtra(BUNDLE_KEY_LAYOUT_RESID, layoutResourceId)
6262
return intent
6363
}
64+
65+
/**
66+
* Creates an intent with required information to start child activity with specific interactive demo.
67+
*
68+
* @param context Activity context.
69+
* @param clazz Activity class that has interactive demo.
70+
* @param layoutResourceId The layout resource ID to load into the view.
71+
*/
72+
fun <T> createStartIntent(context: Context, clazz: Class<T>, @LayoutRes layoutResourceId: Int): Intent {
73+
val intent = Intent(context, clazz)
74+
intent.putExtra(BUNDLE_KEY_LAYOUT_RESID, layoutResourceId)
75+
return intent
76+
}
6477
}
6578

6679
@Inject

app/src/main/java/com/hossainkhan/android/demo/layoutpreview/LayoutVisibilityGoneActivity.kt

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,28 +16,17 @@
1616

1717
package com.hossainkhan.android.demo.layoutpreview
1818

19-
import android.content.Context
20-
import android.content.Intent
2119
import android.os.Bundle
2220
import android.view.View
2321
import android.widget.Button
2422
import com.hossainkhan.android.demo.R
2523

24+
/**
25+
* Activity showcasing how visibility GONE affects constraints.
26+
*
27+
* See https://developer.android.com/reference/android/support/constraint/ConstraintLayout#VisibilityBehavior
28+
*/
2629
class LayoutVisibilityGoneActivity : LayoutPreviewBaseActivity() {
27-
28-
companion object {
29-
/**
30-
* Creates an intent with required information to start this activity.
31-
*
32-
* @param context Activity context.
33-
*/
34-
fun createStartIntent(context: Context): Intent {
35-
val intent = Intent(context, LayoutVisibilityGoneActivity::class.java)
36-
intent.putExtra(BUNDLE_KEY_LAYOUT_RESID, R.layout.preview_visibility_gone)
37-
return intent
38-
}
39-
}
40-
4130
override fun onCreate(savedInstanceState: Bundle?) {
4231
super.onCreate(savedInstanceState)
4332

0 commit comments

Comments
 (0)