Skip to content

Commit 42ae20d

Browse files
authored
Merge branch 'main' into master
2 parents fbae474 + 040035e commit 42ae20d

File tree

5 files changed

+17
-13
lines changed

5 files changed

+17
-13
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ COPY autoinstall.template /opt/helpers/
2929
COPY installer.sh /opt/helpers/
3030
COPY entrypoint.sh /entrypoint.sh
3131

32-
ARG GOLANG_VERSION=1.23.5
32+
ARG GOLANG_VERSION=1.23.6
3333

3434
RUN apt-get update && \
3535
apt-get install -y curl wget git gcc make vim libhwloc-dev hwloc software-properties-common man-db && \

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
# This Makefile is used for development and testing purposes only.
2222

2323
IMAGE_NAME = $(shell basename $(CURDIR))
24-
IMAGE_TAG = V901_TAG
24+
IMAGE_TAG = V902_TAG
2525
CONTAINER_NAME = $(IMAGE_NAME)
2626

2727
.PHONY: build

pkg/qacct/v9.0/file_test.go

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,34 +25,35 @@ var _ = Describe("File", func() {
2525

2626
It("returns a channel that emits JobDetail objects for 10 jobs", func() {
2727

28+
jobDetailsChan, err := qacct.WatchFile(context.Background(),
29+
qacct.GetDefaultQacctFile(), 0)
30+
Expect(err).NotTo(HaveOccurred())
31+
Expect(jobDetailsChan).NotTo(BeNil())
32+
2833
qs, err := qsub.NewCommandLineQSub(qsub.CommandLineQSubConfig{})
2934
Expect(err).NotTo(HaveOccurred())
3035

3136
jobIDs := make([]int, 10)
3237
for i := 0; i < 10; i++ {
33-
jobID, _, err := qs.Submit(context.Background(), qsub.JobOptions{
34-
Command: "echo",
35-
CommandArgs: []string{fmt.Sprintf("job %d", i+1)},
36-
Binary: qsub.ToPtr(true),
37-
})
38+
jobID, _, err := qs.Submit(context.Background(),
39+
qsub.JobOptions{
40+
Command: "/bin/bash",
41+
CommandArgs: []string{"-c", fmt.Sprintf("echo job %d; sleep 0", i+1)},
42+
Binary: qsub.ToPtr(true),
43+
})
3844
Expect(err).NotTo(HaveOccurred())
3945
log.Printf("jobID: %d", jobID)
4046
jobIDs[i] = int(jobID)
4147
}
4248

43-
jobDetailsChan, err := qacct.WatchFile(context.Background(),
44-
qacct.GetDefaultQacctFile(), 0)
45-
Expect(err).NotTo(HaveOccurred())
46-
Expect(jobDetailsChan).NotTo(BeNil())
47-
4849
receivedJobs := make(map[int]bool)
4950
Eventually(func() bool {
5051
select {
5152
case jd := <-jobDetailsChan:
5253
log.Printf("job: %+v", jd.JobNumber)
5354
// check if jobID is in the jobIDs list
5455
if slices.Contains(jobIDs, int(jd.JobNumber)) {
55-
Expect(jd.SubmitCommandLine).To(ContainSubstring("echo 'job"))
56+
Expect(jd.SubmitCommandLine).To(ContainSubstring("bash"))
5657
Expect(jd.JobUsage.Usage.Memory).To(BeNumerically(">=", 0))
5758
receivedJobs[int(jd.JobNumber)] = true
5859
}

pkg/qstat/v9.0/parser_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -516,6 +516,7 @@ test.q@master BIP 0/0/10 0.55 lx-amd64
516516

517517
Expect(full[1].QueueName).To(Equal("test.q@master"))
518518
Expect(full[1].Jobs).To(HaveLen(0))
519+
519520
})
520521

521522
})

pkg/qstat/v9.0/qstat.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@ type QStat interface {
4545
ShowFullOutputWithResources(resourceAttributes string) ([]JobInfo, error)
4646
// qstat -g c
4747
DisplayClusterQueueSummary() ([]ClusterQueueSummary, error)
48+
// qstat -g d shows all job array tasks individually
4849
DisplayAllJobArrayTasks() ([]JobArrayTask, error)
50+
// qstat -g p shows all parallel job tasks individually
4951
DisplayAllParallelJobTasks() ([]ParallelJobTask, error)
5052
// qstat -help
5153
ShowHelp() (string, error)

0 commit comments

Comments
 (0)