fix(ContextMenu): left clicking trigger should close when open (#1848)

Author: huntabyte

.changeset/fifty-plums-eat.md

@@ -0,0 +1,5 @@
+---
+"bits-ui": patch
+---
+
+fix(ContextMenu): left clicking the trigger when open should register as outside click event

packages/bits-ui/src/lib/bits/utilities/dismissible-layer/use-dismissable-layer.svelte.ts

@@ -255,6 +255,7 @@ function isValidEvent(e: PointerEvent, node: HTMLElement): boolean {
 
 	const targetIsContextMenuTrigger = Boolean(target.closest(`[${CONTEXT_MENU_TRIGGER_ATTR}]`));
 	if ("button" in e && e.button > 0 && !targetIsContextMenuTrigger) return false;
+	if ("button" in e && e.button === 0 && targetIsContextMenuTrigger) return true;
 
 	const nodeIsContextMenu = Boolean(node.closest(`[${CONTEXT_MENU_CONTENT_ATTR}]`));
 	if (targetIsContextMenuTrigger && nodeIsContextMenu) return false;

tests/src/tests/context-menu/context-menu.browser.test.ts

@@ -475,3 +475,9 @@ it("should open when right clicked inside a tooltip trigger", async () => {
 	await page.getByTestId("context-menu-trigger").click({ button: "right" });
 	await expectExists(page.getByTestId("context-menu-content"));
 });
+
+it("should close when the trigger is left clicked and the menu is open", async () => {
+	await open();
+	await page.getByTestId("trigger").click({ force: true });
+	await expectNotExists(page.getByTestId("content"));
+});