Optimized code. (#2652)

limingxinleo · web-flow · commit 39c0f71c6c3a · 2020-10-14T08:57:43.000+08:00
diff --git a/src/Client.php b/src/Client.php
@@ -71,12 +71,12 @@ public function recv(float $timeout = -1)
     }
 
     /**
-     * @param bool|int $finish TODO: When swoole version >= 4.4.12, `finish` is SWOOLE_WEBSOCKET_FLAG_FIN or SWOOLE_WEBSOCKET_FLAG_COMPRESS
+     * @param int $flags SWOOLE_WEBSOCKET_FLAG_FIN or SWOOLE_WEBSOCKET_FLAG_COMPRESS
      */
-    public function push(string $data, int $opcode = WEBSOCKET_OPCODE_TEXT, $finish = null): bool
+    public function push(string $data, int $opcode = WEBSOCKET_OPCODE_TEXT, int $flags = null): bool
     {
-        if (isset($finish)) {
-            return $this->client->push($data, $opcode, $finish);
+        if (isset($flags)) {
+            return $this->client->push($data, $opcode, $flags);
         }
         return $this->client->push($data, $opcode);
     }

Original file line number	Diff line number	Diff line change
`@@ -71,12 +71,12 @@ public function recv(float $timeout = -1)`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`/**`
`74`		- * @param bool\|int $finish TODO: When swoole version >= 4.4.12, `finish` is SWOOLE_WEBSOCKET_FLAG_FIN or SWOOLE_WEBSOCKET_FLAG_COMPRESS
	`74`	`+ * @param int $flags SWOOLE_WEBSOCKET_FLAG_FIN or SWOOLE_WEBSOCKET_FLAG_COMPRESS`
`75`	`75`	`*/`
`76`		`- public function push(string $data, int $opcode = WEBSOCKET_OPCODE_TEXT, $finish = null): bool`
	`76`	`+ public function push(string $data, int $opcode = WEBSOCKET_OPCODE_TEXT, int $flags = null): bool`
`77`	`77`	`{`
`78`		`- if (isset($finish)) {`
`79`		`- return $this->client->push($data, $opcode, $finish);`
	`78`	`+ if (isset($flags)) {`
	`79`	`+ return $this->client->push($data, $opcode, $flags);`
`80`	`80`	`}`
`81`	`81`	`return $this->client->push($data, $opcode);`
`82`	`82`	`}`