Skip to content

Commit 292c4eb

Browse files
mbwhitejt-nti
authored andcommitted
Update the build.gradle for publishing
The updated versions of gradle appear to require a slightly different way of publishing. Based on a local empirical test, these changes appear to be sound Signed-off-by: Matthew B White <whitemat@uk.ibm.com>
1 parent 4ea0f71 commit 292c4eb

File tree

4 files changed

+13
-21
lines changed

4 files changed

+13
-21
lines changed

ci/azure-pipelines.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,8 +198,8 @@ stages:
198198
inputs:
199199
secureFile: secring.gpg
200200
- script: |
201-
./gradlew -Psigning.keyId=${SIGNING_ID} -Psigning.password=${SIGNING_PASSWORD} -Psigning.secretKeyRingFile=${KEYRING_FILE} -PossrhUsername=${OSSRH_USER} -PossrhPassword=${OSSRH_PASSWORD} publishMavenPublicationToReleaseRepository
202-
./gradlew -Psigning.keyId=${SIGNING_ID} -Psigning.password=${SIGNING_PASSWORD} -Psigning.secretKeyRingFile=${KEYRING_FILE} -PossrhUsername=${OSSRH_USER} -PossrhPassword=${OSSRH_PASSWORD} publishMavenPublicationToSnapshotRepository
201+
./gradlew -Psigning.keyId=${SIGNING_ID} -Psigning.password=${SIGNING_PASSWORD} -Psigning.secretKeyRingFile=${KEYRING_FILE} -PossrhUsername=${OSSRH_USER} -PossrhPassword=${OSSRH_PASSWORD} publishAllPublicationsToReleaseRepository
202+
./gradlew -Psigning.keyId=${SIGNING_ID} -Psigning.password=${SIGNING_PASSWORD} -Psigning.secretKeyRingFile=${KEYRING_FILE} -PossrhUsername=${OSSRH_USER} -PossrhPassword=${OSSRH_PASSWORD} publishAllPublicationsToSnapshotRepository
203203
env:
204204
SIGNING_ID: $(JAR-Signing-Id)
205205
SIGNING_PASSWORD: $(JAR-Signing-Password)

fabric-chaincode-protos/build.gradle

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,6 @@ if (JavaVersion.current().isJava8Compatible()) {
114114
}
115115
}
116116

117-
task javadocJar(type: Jar) {
118-
classifier = 'javadoc'
119-
from javadoc
120-
}
121117

122118

123119
publishing {
@@ -224,11 +220,7 @@ signing {
224220
}
225221
}
226222

227-
task sourcesJar(type: Jar) {
228-
classifier = 'sources'
229-
from sourceSets.main.allSource
230-
}
231-
232-
artifacts {
233-
archives javadocJar, sourcesJar
223+
java {
224+
withJavadocJar()
225+
withSourcesJar()
234226
}

fabric-chaincode-shim/build.gradle

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -223,10 +223,6 @@ if (JavaVersion.current().isJava8Compatible()) {
223223
}
224224
}
225225

226-
task javadocJar(type: Jar) {
227-
classifier = 'javadoc'
228-
from javadoc
229-
}
230226

231227
publishing {
232228
publications {
@@ -333,18 +329,22 @@ signing {
333329
}
334330
}
335331

332+
// Need to specify the sourcesJar task BEFORE the java{withSourcesJar()} so that it picks up the duplicatesStratergy
333+
// otherwise this fails with a duplicates error.
334+
// (see https://github.com/gradle/gradle/issues/17236)
335+
336336
task sourcesJar(type: Jar) {
337337
duplicatesStrategy = 'include'
338338
classifier = 'sources'
339339
from sourceSets.main.allSource
340340
}
341341

342-
artifacts {
343-
archives javadocJar, sourcesJar
342+
java {
343+
withJavadocJar()
344+
withSourcesJar()
344345
}
345346

346347

347-
348348
build.dependsOn licenseCheck
349349

350350
// setup more detailed test output formats
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.0-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-7.1.1-bin.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

0 commit comments

Comments
 (0)