Ensure that SimpleDateFormat::fUsePlainSpaces is always initialized (swiftlang#40) (swiftlang#41)

jmschonfeld · web-flow · commit 21c6e69969af · 2024-08-01T08:35:58.000-07:00
diff --git a/icuSources/i18n/smpdtfmt.cpp b/icuSources/i18n/smpdtfmt.cpp
@@ -1341,6 +1341,8 @@ SimpleDateFormat::initialize(const Locale& locale,
         fUsePlainSpaces = true;
         os_log(OS_LOG_DEFAULT, "ICU using compatibility space for date formatting");
     }
+#else
+    fUsePlainSpaces = false;
 #endif  // APPLE_ICU_CHANGES && U_PLATFORM_IS_DARWIN_BASED
 
     parsePattern(); // Need this before initNumberFormatters(), to set fHasHanYearChar

Original file line number	Diff line number	Diff line change
`@@ -1341,6 +1341,8 @@ SimpleDateFormat::initialize(const Locale& locale,`
`1341`	`1341`	`fUsePlainSpaces = true;`
`1342`	`1342`	`os_log(OS_LOG_DEFAULT, "ICU using compatibility space for date formatting");`
`1343`	`1343`	`}`
	`1344`	`+#else`
	`1345`	`+ fUsePlainSpaces = false;`
`1344`	`1346`	`#endif // APPLE_ICU_CHANGES && U_PLATFORM_IS_DARWIN_BASED`
`1345`	`1347`
`1346`	`1348`	`parsePattern(); // Need this before initNumberFormatters(), to set fHasHanYearChar`