fix for buggy drilldown from summary table to grid

Fixes #780

Author: starpit

app/plugins/modules/activation-visualizations/lib/table.js

@@ -572,7 +572,7 @@ const _drawTable = (options, header, content, groupData, eventBus, sorter=defaul
                 } else {
                     // drill down to grid, showing just successes
                     cell.classList.add('clickable')
-                    cell.onclick = drilldownWith(viewName, `grid ${optionsToString(options)} --success --zoom 1 --name "${group.path}" ${splitOptions}`)
+                    cell.onclick = drilldownWith(viewName, `grid "${group.path}" ${optionsToString(options)} --success ${splitOptions}`)
                 }
                 cell.appendChild(countPart)
                 countPart.innerText = group.nSuccesses
@@ -602,7 +602,7 @@ const _drawTable = (options, header, content, groupData, eventBus, sorter=defaul
 
                 // drill down to grid, showing just failures
                 cell.classList.add('clickable')
-                cell.onclick = drilldownWith(viewName, `grid ${optionsToString(options)} --failure --zoom 1 --name "${group.path}" ${splitOptions}`)
+                cell.onclick = drilldownWith(viewName, `grid "${group.path}" ${optionsToString(options)} --failure ${splitOptions}`)
                 if (group.nFailures === 0) {
                     cell.classList.add('count-is-zero')
                     cell.classList.remove('clickable')

tests/tests/passes/05/activation-table-view.js

@@ -34,7 +34,7 @@ const parsesAsInteger = str => {
 }
 const isInteger = str => typeof str === 'number' || parsesAsInteger(str)
 
-const openTableExpectCountOf = function(ctx, expectedCount, expectedErrorRate, cmd) {
+const _openTableExpectCountOf = function(ctx, expectedCount, expectedErrorRate, cmd) {
     const view = `${ui.selectors.SIDECAR_CUSTOM_CONTENT} .activation-viz-plugin`,
           row = `${view} tr[data-action-name="${actionName}"]`,
           successCell = `${row} .cell-successes.cell-hide-when-outliers-shown`,
@@ -79,7 +79,12 @@ const openTableExpectCountOf = function(ctx, expectedCount, expectedErrorRate, c
               }
           });
 
-    it(`open activation table, with ${cmd}`, () => new Promise((resolve, reject) => once(0, resolve, reject)))
+    return new Promise((resolve, reject) => once(0, resolve, reject))
+}
+const openTableExpectCountOf = function() {
+    const cmd = arguments[arguments.length - 1]
+
+    it(`open activation table, with ${cmd}`, () => _openTableExpectCountOf.apply(this, arguments))
 }
 exports.openTableExpectCountOf = openTableExpectCountOf
 
@@ -150,6 +155,15 @@ describe('Activation table visualization', function() {
     openTableExpectCountOf(this, 3, 1, 'summary')
     openTableExpectCountOf(this, 3, 1, 'summary --batches 10')
 
+    it('should open table, click on a failure cell, and show grid', () => _openTableExpectCountOf(this, 3, 1, 'summary --batches 10')
+       .then(() => `${ui.selectors.SIDECAR_CUSTOM_CONTENT} tr[data-action-name="${actionName}"] .cell-errors`)
+       .then(selector => this.app.client.scroll(selector)
+             .then(this.app.client.click(selector)))
+       .then(() => this.app)
+       .then(sidecar.expectOpen)
+       .then(sidecar.expectMode('grid'))
+       .catch(common.oops(this)))
+
     // force a version update
     it('should create the action that bombs if the input value is negative', () => cli.do(`let ${actionName} = ({x}) => x<0 ? {error:'bomb!'} : {x: x}`, this.app)
         .then(cli.expectOK)