Skip to content

Commit 59625ad

Browse files
committed
remove sync block in threadState() method
update formating Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
1 parent 4fea58c commit 59625ad

File tree

1 file changed

+23
-24
lines changed

1 file changed

+23
-24
lines changed

src/java.base/share/classes/java/lang/Thread.java

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -2429,32 +2429,33 @@ public State getState() {
24292429
/**
24302430
* Returns the translation from a J9VMThread state to a Thread::State.
24312431
*
2432+
* @param status thread status value set by VM.
24322433
* @return this thread's state.
24332434
*
24342435
* @see State
24352436
*/
24362437
private State translateJ9VMThreadStateToThreadState(int status) {
24372438
switch (status) {
2438-
case 1: // J9VMTHREAD_STATE_RUNNING
2439-
return State.RUNNABLE;
2440-
case 2: // J9VMTHREAD_STATE_BLOCKED
2441-
return State.BLOCKED;
2442-
case 4: // J9VMTHREAD_STATE_WAITING
2443-
case 0x80: // J9VMTHREAD_STATE_PARKED
2444-
return State.WAITING;
2445-
case 8: // J9VMTHREAD_STATE_SLEEPING
2446-
case 64: // J9VMTHREAD_STATE_WAITING_TIMED
2447-
case 0x100: // J9VMTHREAD_STATE_PARKED_TIMED
2448-
return State.TIMED_WAITING;
2449-
case 32: // J9VMTHREAD_STATE_DEAD
2450-
return State.TERMINATED;
2451-
default:
2452-
synchronized (interruptLock) {
2453-
if (eetop == NO_REF) {
2454-
return State.TERMINATED;
2455-
}
2456-
return State.values()[getStateImpl(eetop)];
2439+
case 1: // J9VMTHREAD_STATE_RUNNING
2440+
return State.RUNNABLE;
2441+
case 2: // J9VMTHREAD_STATE_BLOCKED
2442+
return State.BLOCKED;
2443+
case 4: // J9VMTHREAD_STATE_WAITING
2444+
case 0x80: // J9VMTHREAD_STATE_PARKED
2445+
return State.WAITING;
2446+
case 8: // J9VMTHREAD_STATE_SLEEPING
2447+
case 64: // J9VMTHREAD_STATE_WAITING_TIMED
2448+
case 0x100: // J9VMTHREAD_STATE_PARKED_TIMED
2449+
return State.TIMED_WAITING;
2450+
case 32: // J9VMTHREAD_STATE_DEAD
2451+
return State.TERMINATED;
2452+
default:
2453+
synchronized (interruptLock) {
2454+
if (eetop == NO_REF) {
2455+
return State.TERMINATED;
24572456
}
2457+
return State.values()[getStateImpl(eetop)];
2458+
}
24582459
}
24592460
}
24602461

@@ -2469,12 +2470,10 @@ State threadState() {
24692470
return State.TERMINATED;
24702471
}
24712472
if (holder == null) {
2472-
synchronized (interruptLock) {
2473-
if (eetop == NO_REF) {
2474-
return State.TERMINATED;
2475-
}
2476-
return State.values()[getStateImpl(eetop)];
2473+
if (eetop == NO_REF) {
2474+
return State.TERMINATED;
24772475
}
2476+
return State.values()[getStateImpl(eetop)];
24782477
}
24792478
return translateJ9VMThreadStateToThreadState(holder.threadStatus);
24802479
}

0 commit comments

Comments
 (0)