Skip to content

Commit bc07a97

Browse files
committed
remove sync block in threadState() method
update formating Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
1 parent ada5d60 commit bc07a97

File tree

1 file changed

+23
-24
lines changed

1 file changed

+23
-24
lines changed

src/java.base/share/classes/java/lang/Thread.java

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -2435,32 +2435,33 @@ public State getState() {
24352435
/**
24362436
* Returns the translation from a J9VMThread state to a Thread::State.
24372437
*
2438+
* @param status thread status value set by VM.
24382439
* @return this thread's state.
24392440
*
24402441
* @see State
24412442
*/
24422443
private State translateJ9VMThreadStateToThreadState(int status) {
24432444
switch (status) {
2444-
case 1: // J9VMTHREAD_STATE_RUNNING
2445-
return State.RUNNABLE;
2446-
case 2: // J9VMTHREAD_STATE_BLOCKED
2447-
return State.BLOCKED;
2448-
case 4: // J9VMTHREAD_STATE_WAITING
2449-
case 0x80: // J9VMTHREAD_STATE_PARKED
2450-
return State.WAITING;
2451-
case 8: // J9VMTHREAD_STATE_SLEEPING
2452-
case 64: // J9VMTHREAD_STATE_WAITING_TIMED
2453-
case 0x100: // J9VMTHREAD_STATE_PARKED_TIMED
2454-
return State.TIMED_WAITING;
2455-
case 32: // J9VMTHREAD_STATE_DEAD
2456-
return State.TERMINATED;
2457-
default:
2458-
synchronized (interruptLock) {
2459-
if (eetop == NO_REF) {
2460-
return State.TERMINATED;
2461-
}
2462-
return State.values()[getStateImpl(eetop)];
2445+
case 1: // J9VMTHREAD_STATE_RUNNING
2446+
return State.RUNNABLE;
2447+
case 2: // J9VMTHREAD_STATE_BLOCKED
2448+
return State.BLOCKED;
2449+
case 4: // J9VMTHREAD_STATE_WAITING
2450+
case 0x80: // J9VMTHREAD_STATE_PARKED
2451+
return State.WAITING;
2452+
case 8: // J9VMTHREAD_STATE_SLEEPING
2453+
case 64: // J9VMTHREAD_STATE_WAITING_TIMED
2454+
case 0x100: // J9VMTHREAD_STATE_PARKED_TIMED
2455+
return State.TIMED_WAITING;
2456+
case 32: // J9VMTHREAD_STATE_DEAD
2457+
return State.TERMINATED;
2458+
default:
2459+
synchronized (interruptLock) {
2460+
if (eetop == NO_REF) {
2461+
return State.TERMINATED;
24632462
}
2463+
return State.values()[getStateImpl(eetop)];
2464+
}
24642465
}
24652466
}
24662467

@@ -2475,12 +2476,10 @@ State threadState() {
24752476
return State.TERMINATED;
24762477
}
24772478
if (holder == null) {
2478-
synchronized (interruptLock) {
2479-
if (eetop == NO_REF) {
2480-
return State.TERMINATED;
2481-
}
2482-
return State.values()[getStateImpl(eetop)];
2479+
if (eetop == NO_REF) {
2480+
return State.TERMINATED;
24832481
}
2482+
return State.values()[getStateImpl(eetop)];
24842483
}
24852484
return translateJ9VMThreadStateToThreadState(holder.threadStatus);
24862485
}

0 commit comments

Comments
 (0)