fix some error on strict mode

Author: inhere

src/Filter/Filters.php

@@ -276,7 +276,7 @@ public static function lower($val): string
     public static function lowercase($val): string
     {
         if (!$val || !is_string($val)) {
-            return is_int($val) ? $val : '';
+            return is_int($val) ? (string)$val: '';
         }
 
         if (function_exists('mb_strtolower')) {
@@ -308,7 +308,7 @@ public static function upper($val): string
     public static function uppercase($str): string
     {
         if (!$str || !is_string($str)) {
-            return is_int($str) ? $str : '';
+            return is_int($str) ? (string)$str : '';
         }
 
         if (function_exists('mb_strtoupper')) {

src/Traits/ScopedValidatorsTrait.php

@@ -352,7 +352,7 @@ public function fileValidator(string $field, $suffixes = null): bool
             return true;
         }
 
-        if (!$suffix = trim(strrchr($file['name'], '.'), '.')) {
+        if (!$suffix = trim((string)strrchr($file['name'], '.'), '.')) {
             return false;
         }
 

src/ValidationTrait.php

@@ -573,6 +573,7 @@ protected function getByWildcard(string $path, $default = null)
                 $result[] = isset($item[$field]) ? $item[$field] : new ArrayValueNotExists();
             }
         }
+
         return $result;
     }
 

src/Validators.php

@@ -351,7 +351,7 @@ public static function accepted($val): bool
      */
     public static function alpha($val): bool
     {
-        return is_string($val) && preg_match('/^(?:[a-zA-Z]+)$/', $val);
+        return is_string($val) && preg_match('/^(?:[a-zA-Z]+)$/', $val) === 1;
     }
 
     /**
@@ -363,11 +363,11 @@ public static function alpha($val): bool
      */
     public static function alphaNum($val): bool
     {
-        if (!is_string($val) && !is_numeric($val)) {
+        if (!is_string($val) || !is_numeric($val)) {
             return false;
         }
 
-        return 1 === preg_match('/^(?:[a-zA-Z0-9]+)$/', $val);
+        return 1 === preg_match('/^(?:[a-zA-Z0-9]+)$/', (string)$val);
     }
 
     /**
@@ -792,7 +792,7 @@ public static function macAddress($input): bool
             return false;
         }
 
-        return preg_match('/^(([0-9a-fA-F]{2}-){5}|([0-9a-fA-F]{2}:){5})[0-9a-fA-F]{2}$/', $input);
+        return 1 === preg_match('/^(([0-9a-fA-F]{2}-){5}|([0-9a-fA-F]{2}:){5})[0-9a-fA-F]{2}$/', $input);
     }
 
     /**

test/RuleValidationTest.php

@@ -691,6 +691,31 @@ public function testIssue13(): void
         $this->assertSame('商品分类id必须是一串数字', $v->firstError());
     }
 
+    /**
+     * @link https://github.com/inhere/php-validate/issues/17
+     */
+    public function tIssues17(): void
+    {
+        $rs = [
+            ['users.*.id', 'required'],
+            ['users.*.id', 'each', 'required'],
+            ['users.*.id', 'each', 'number', 'min' => 34, 'msg' => [
+                'min' 	 => 'xxx error',
+                'number' => 'xxx error',
+            ]],
+        ];
+
+        $v = RV::check([
+            'users' => [
+                ['id' => 12,],
+                ['id' => 23],
+            ],
+        ], $rs);
+
+        $this->assertFalse($v->isOk());
+        $this->assertSame('parameter users.*.id is required!', $v->firstError());
+    }
+
     /**
      * @link https://github.com/inhere/php-validate/issues/21
      */

test/ValidationTraitTest.php

@@ -34,6 +34,10 @@ public function testGetByPath(): void
                     'attr' => [
                         'wid' => 1
                     ]
+                ],
+                'users' => [
+                    ['id' => 1,],
+                    ['id' => 2,]
                 ]
             ]
         ]);
@@ -50,6 +54,10 @@ public function testGetByPath(): void
         $val = $v->getByPath('prod.*.attr');
         $this->assertSame([['wid' => 1]], $val);
 
+        // TODO ..
+        // $val = $v->getByPath('users.*.id');
+        // $this->assertSame([1, 2], $val);
+
         // $val = $v->getByPath('prod.*.attr.wid');
         // $this->assertSame([1], $val);
     }

test/ValidatorsTest.php

@@ -135,6 +135,7 @@ public function testAlphaNum(): void
     {
         $this->assertFalse(Validators::alphaNum('='));
         $this->assertFalse(Validators::alphaNum(null));
+        $this->assertFalse(Validators::alphaNum(true));
         $this->assertFalse(Validators::alphaNum([]));
         $this->assertTrue(Validators::alphaNum(5));
         $this->assertTrue(Validators::alphaNum('5'));