Exclude ArrayAccess methods from type declarations checks

Author: gmazzap

Inpsyde/Sniffs/CodeQuality/ArgumentTypeDeclarationSniff.php

@@ -41,7 +41,10 @@ public function register()
      */
     public function process(File $file, $position)
     {
-        if (Helpers::isHookClosure($file, $position) || Helpers::isHookFunction($file, $position)) {
+        if (Helpers::functionIsArrayAccess($file, $position)
+            || Helpers::isHookClosure($file, $position)
+            || Helpers::isHookFunction($file, $position)
+        ) {
             return;
         }
 

Inpsyde/Sniffs/CodeQuality/ReturnTypeDeclarationSniff.php

@@ -41,6 +41,10 @@ public function register()
      */
     public function process(File $file, $position)
     {
+        if (Helpers::functionIsArrayAccess($file, $position)) {
+            return;
+        }
+
         list($functionStart, $functionEnd) = Helpers::functionBoundaries($file, $position);
         if (!$functionStart < 0 || $functionEnd <= 0) {
             return;

tests/fixtures/argument-type-declaration.php

@@ -213,3 +213,33 @@ function b(array $foo, $bar);
 
     function d(array $foo, ArrayObject $bar);
 }
+
+class FooAccess implements ArrayAccess {
+
+    /**
+     * @inheritdoc
+     */
+    public function offsetExists($offset)
+    {
+        return false;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function offsetGet($offset)
+    {
+        return false;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function offsetSet($offset, $value)
+    {
+    }
+
+    public function offsetUnset($offset)
+    {
+    }
+}

tests/fixtures/return-type-declaration.php

@@ -192,4 +192,34 @@ public function test2();
      * @return bool
      */
     public function test3(): bool ;
+}
+
+class FooAccess implements ArrayAccess {
+
+    /**
+     * @inheritdoc
+     */
+    public function offsetExists($offset)
+    {
+        return false;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function offsetGet($offset)
+    {
+        return false;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function offsetSet($offset, $value)
+    {
+    }
+
+    public function offsetUnset($offset)
+    {
+    }
 }