Merge pull request #34 from inpsyde/issue-32

Allow blank line after single line declaration #32

Author: gmazzap

Inpsyde/Sniffs/CodeQuality/FunctionBodyStartSniff.php

@@ -86,7 +86,7 @@ private function checkBodyStart(
 
         $error =
             ($isMultiLineDeclare || $isSingleLineSignature) && $bodyLine !== ($openerLine + 2)
-            || $isSingleLineDeclare && $bodyLine !== ($openerLine + 1);
+            || $isSingleLineDeclare && $bodyLine > ($openerLine + 2);
 
         if (!$error) {
             return [null, null, null];

tests/fixtures/function-body-start.php

@@ -8,13 +8,21 @@ function foo()
     return 'foo';
 }
 
-// @phpcsWarningCodeOnNextLine WrongForSingleLineDeclaration
+// tolerate this as PHPStorm code styler cannot distinguish between
+// single line and multiline function declarations. See issue #32
 function bar()
 {
 
     return 'bar';
 }
 
+// @phpcsWarningCodeOnNextLine WrongForSingleLineSignature
+function lorem() {
+
+
+    return 'ipsum';
+}
+
 // @phpcsWarningCodeOnNextLine WrongForMultiLineDeclaration
 function fooFoo(
     string $foo,
@@ -66,13 +74,19 @@ public function foo()
         return 'foo';
     }
 
-    // @phpcsWarningCodeOnNextLine WrongForSingleLineDeclaration
     private function bar()
     {
 
         return 'bar';
     }
 
+    // @phpcsWarningCodeOnNextLine WrongForSingleLineSignature
+    public function lorem() {
+
+
+        return 'ipsum';
+    }
+
     // @phpcsWarningCodeOnNextLine WrongForMultiLineDeclaration
     protected function fooFoo(
         string $foo,