Skip to content

Commit 51d9282

Browse files
committed
Bump external vm protobuf definition
1 parent c9c73cd commit 51d9282

File tree

5 files changed

+25
-10
lines changed

5 files changed

+25
-10
lines changed

src/main/protobuf/extvm

src/main/scala/io/iohk/ethereum/extvm/VMClient.scala

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,13 @@ class VMClient(externalVmConfig: VmConfig.ExternalConfig, messageHandler: Messag
171171
eip150BlockNumber = blockchainConfig.eip150BlockNumber,
172172
eip160BlockNumber = blockchainConfig.eip160BlockNumber,
173173
eip161BlockNumber = blockchainConfig.eip161BlockNumber,
174+
byzantiumBlockNumber = blockchainConfig.byzantiumBlockNumber,
175+
constantinopleBlockNumber = blockchainConfig.constantinopleBlockNumber,
176+
petersburgBlockNumber = blockchainConfig.petersburgBlockNumber,
177+
istanbulBlockNumber = blockchainConfig.istanbulBlockNumber,
174178
maxCodeSize = blockchainConfig.maxCodeSize.map(bigintToGByteString).getOrElse(ByteString()),
175-
accountStartNonce = blockchainConfig.accountStartNonce
179+
accountStartNonce = blockchainConfig.accountStartNonce,
180+
chainId = ByteString(blockchainConfig.chainId)
176181
)
177182

178183
private def buildIeleConfigMsg(): msg.IeleConfig =

src/main/scala/io/iohk/ethereum/extvm/VMServer.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -198,17 +198,17 @@ class VMServer(messageHandler: MessageHandler) extends Logger {
198198
eip150BlockNumber = conf.eip150BlockNumber,
199199
eip160BlockNumber = conf.eip160BlockNumber,
200200
eip161BlockNumber = conf.eip161BlockNumber,
201-
byzantiumBlockNumber = BigInt(4370000), //TODO include byzantium block number in protobuf
202-
constantinopleBlockNumber = BigInt(10000000), //TODO include constantinople block number in protobuf
203-
istanbulBlockNumber = BigInt(10000000), //TODO include istanbul block number in protobuf
201+
byzantiumBlockNumber = conf.byzantiumBlockNumber,
202+
constantinopleBlockNumber = conf.constantinopleBlockNumber,
203+
istanbulBlockNumber = conf.istanbulBlockNumber,
204204
maxCodeSize = if (conf.maxCodeSize.isEmpty) None else Some(bigintFromGByteString(conf.maxCodeSize)),
205205
accountStartNonce = conf.accountStartNonce,
206206
atlantisBlockNumber = BigInt(8772000), //TODO include atlantis block number in protobuf
207207
aghartaBlockNumber = BigInt(9573000), //TODO include agharta block number in protobuf
208-
petersburgBlockNumber = BigInt(10000000), //TODO include petersburg block number in protobuf
208+
petersburgBlockNumber = conf.petersburgBlockNumber,
209209
phoenixBlockNumber = BigInt(10500839), //TODO include phoenix block number in protobuf
210210
magnetoBlockNumber = BigInt(13189133), //TODO include magneto block number in protobuf
211211
berlinBlockNumber = BigInt("1000000000000000000"), //TODO include berlin block number in protobuf
212-
chainId = 0x3d.toByte //TODO include chainId in protobuf
212+
chainId = conf.chainId.byteAt(0)
213213
)
214214
}

src/test/scala/io/iohk/ethereum/extvm/VMClientSpec.scala

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,13 @@ class VMClientSpec extends AnyFlatSpec with Matchers with MockFactory {
166166
eip150BlockNumber = forkBlockNumbers.eip150BlockNumber,
167167
eip160BlockNumber = forkBlockNumbers.eip160BlockNumber,
168168
eip161BlockNumber = forkBlockNumbers.eip161BlockNumber,
169+
byzantiumBlockNumber = forkBlockNumbers.byzantiumBlockNumber,
170+
constantinopleBlockNumber = forkBlockNumbers.constantinopleBlockNumber,
171+
petersburgBlockNumber = forkBlockNumbers.petersburgBlockNumber,
172+
istanbulBlockNumber = forkBlockNumbers.istanbulBlockNumber,
169173
maxCodeSize = blockchainConfig.maxCodeSize.get,
170-
accountStartNonce = blockchainConfig.accountStartNonce
174+
accountStartNonce = blockchainConfig.accountStartNonce,
175+
chainId = ByteString(blockchainConfig.chainId)
171176
)
172177
val expectedHelloConfigMsg = msg.Hello.Config.EthereumConfig(expectedEthereumConfig)
173178
val expectedHelloMsg = msg.Hello(version = "testVersion", config = expectedHelloConfigMsg)

src/test/scala/io/iohk/ethereum/extvm/VMServerSpec.scala

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,16 @@ class VMServerSpec extends AnyFlatSpec with Matchers with MockFactory {
113113
eip150BlockNumber = forkBlockNumbers.eip150BlockNumber,
114114
eip160BlockNumber = forkBlockNumbers.eip160BlockNumber,
115115
eip161BlockNumber = forkBlockNumbers.eip161BlockNumber,
116+
byzantiumBlockNumber = forkBlockNumbers.byzantiumBlockNumber,
117+
constantinopleBlockNumber = forkBlockNumbers.constantinopleBlockNumber,
118+
petersburgBlockNumber = forkBlockNumbers.petersburgBlockNumber,
119+
istanbulBlockNumber = forkBlockNumbers.istanbulBlockNumber,
116120
maxCodeSize = ByteString(),
117-
accountStartNonce = blockchainConfig.accountStartNonce
121+
accountStartNonce = blockchainConfig.accountStartNonce,
122+
chainId = ByteString(blockchainConfig.chainId)
118123
)
119124
val ethereumConfigMsg: Hello.Config.EthereumConfig = msg.Hello.Config.EthereumConfig(ethereumConfig)
120-
val helloMsg: Hello = msg.Hello(version = "2.0", config = ethereumConfigMsg)
125+
val helloMsg: Hello = msg.Hello(version = "2.1", config = ethereumConfigMsg)
121126

122127
val messageHandler: MessageHandler = mock[MessageHandler]
123128
val vmServer = new VMServer(messageHandler)

0 commit comments

Comments
 (0)