Skip to content

Commit abd3b9b

Browse files
CaoEchunyuan-w
andauthored
Add test cases for isa check to improve code coverage (#3598)
* add test cases for isa check to improve code coverage * fix typo * minor fix --------- Co-authored-by: Chunyuan WU <chunyuan.wu@intel.com>
1 parent 43e7867 commit abd3b9b

File tree

1 file changed

+25
-6
lines changed

1 file changed

+25
-6
lines changed

tests/cpu/test_dyndisp.py

Lines changed: 25 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def get_ipex_isa_env_setting():
4242
return env_isa
4343

4444

45-
def get_currnet_isa_level():
45+
def get_current_isa_level():
4646
return core._get_current_isa_level().lower()
4747

4848

@@ -61,7 +61,7 @@ def check_not_sync_onednn_isa_level():
6161
class TestDynDisp(unittest.TestCase):
6262
def test_manual_select_kernel(self):
6363
env_isa = get_ipex_isa_env_setting()
64-
cur_isa = get_currnet_isa_level()
64+
cur_isa = get_current_isa_level()
6565
max_bin_isa = get_highest_binary_support_isa_level()
6666
max_cpu_isa = get_highest_cpu_support_isa_level()
6767

@@ -70,12 +70,12 @@ def test_manual_select_kernel(self):
7070
if env_isa is not None:
7171
expected_isa_val = min(get_isa_val(env_isa), expected_isa_val)
7272

73-
actural_isa_val = get_isa_val(cur_isa)
73+
actual_isa_val = get_isa_val(cur_isa)
7474

7575
# Isa level and compiler version are not linear relationship.
7676
# gcc 9.4 can build avx512_vnni.
7777
# gcc 11.3 start to support avx2_vnni.
78-
self.assertTrue(actural_isa_val <= expected_isa_val)
78+
self.assertTrue(actual_isa_val <= expected_isa_val)
7979
return
8080

8181
def test_dyndisp_in_supported_set(self):
@@ -84,7 +84,7 @@ def test_dyndisp_in_supported_set(self):
8484
if env_isa is not None:
8585
return
8686

87-
cur_isa = get_currnet_isa_level()
87+
cur_isa = get_current_isa_level()
8888
expected_isa = cur_isa in supported_isa_set
8989

9090
self.assertTrue(expected_isa)
@@ -109,7 +109,7 @@ def test_ipex_set_onednn_isa_level(self):
109109
def test_onednn_do_not_set_isa_level(self):
110110
command = 'ONEDNN_MAX_CPU_ISA=avx2 python -c "import torch; import intel_extension_for_pytorch._C \
111111
as core; print(core._get_current_isa_level().lower())" '
112-
cur_ipex_isa = get_currnet_isa_level()
112+
cur_ipex_isa = get_current_isa_level()
113113
with subprocess.Popen(
114114
command, shell=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT
115115
) as p:
@@ -118,5 +118,24 @@ def test_onednn_do_not_set_isa_level(self):
118118
self.assertTrue(cur_ipex_isa == cur_ipex_isa_1)
119119

120120

121+
class TestIsaCheck(unittest.TestCase):
122+
def test_isa_check(self):
123+
cur_isa = get_current_isa_level()
124+
actual_isa_val = get_isa_val(cur_isa)
125+
if actual_isa_val >= 6:
126+
self.assertTrue(core.isa_has_amx_support())
127+
self.assertTrue(core.isa_has_avx512_bf16_support())
128+
self.assertTrue(core.isa_has_avx512_vnni_support())
129+
self.assertTrue(core.isa_has_avx512_support())
130+
self.assertTrue(core.isa_has_avx2_vnni_support())
131+
self.assertTrue(core.isa_has_avx2_support())
132+
elif actual_isa_val >= 3:
133+
self.assertTrue(core.isa_has_avx512_support())
134+
self.assertTrue(core.isa_has_avx2_support())
135+
elif actual_isa_val >= 2:
136+
self.assertTrue(core.isa_has_avx2_vnni_support())
137+
self.assertTrue(core.isa_has_avx2_support())
138+
139+
121140
if __name__ == "__main__":
122141
unittest.main()

0 commit comments

Comments
 (0)