Commit 7761eb2
authored
[SYCL][E2E] Better control of testing
Before the PR we had two modes:
* Default, auto-detect preview support in toolchain and have individual
tests run dedicated `RUN`-lines
* `--param test-preview-mode=<anything but False>`, run entire suite in
preview mode using non-preview `RUN`-lines. Special `RUN`-lines
dedicated to preview are ignored.
This PR changes it to this:
* Only allow `test-preview-mode` to be unset or set to True/False, fatal
error on any other value.
* If True/unset behave as in two previous scenarios
* If False, only execute `RUN`-lines without preview markup
I need this for compatibility testing because preview mode isn't
backward ABI-compatible and I'm going to cherry-pick this to
`sycl-rel-6_[23]`
For trunk, I think we should just remove special `RUN`-lines and rely on
"full preview" mode job in CI, but that will be a separate PR (because I
wouldn't be able to backport such a big change).
Cherry-picks #19727preview-mode (#19735)1 parent 845d817 commit 7761eb2
1 file changed
+6
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
342 | 342 | | |
343 | 343 | | |
344 | 344 | | |
345 | | - | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
346 | 350 | | |
347 | | - | |
| 351 | + | |
348 | 352 | | |
349 | 353 | | |
350 | 354 | | |
| |||
0 commit comments