Merge pull request #15 from iolufemi/bugFix/forbiddenStatusCode

Bug fix/forbidden status code

Author: iolufemi

README.md

@@ -2,7 +2,7 @@
 
 [![Build Status](https://travis-ci.org/iolufemi/Express-REST-API-Generator.svg?branch=dev)](https://travis-ci.org/iolufemi/Express-REST-API-Generator)  [![codecov](https://codecov.io/gh/iolufemi/Express-REST-API-Generator/branch/master/graph/badge.svg)](https://codecov.io/gh/iolufemi/Express-REST-API-Generator) [![Documentation Status](https://readthedocs.org/projects/api-template/badge/?version=latest)](http://api-template.readthedocs.io/en/latest/?badge=latest)
 
-Express REST API Generator is an Express Based API skeleton. A template for starting projects with express as an API. This project can be used for creating a RESTful API using Node JS, Express as the framework and Mongoose to interact with a MongoDB instance. Mocha is also used for running unit tests in the project.
+Express REST API Generator is an Express Based API skeleton. A template for starting projects with express as an API. This project can be used for creating a RESTful API using Node JS, Express as the framework, Mongoose to interact with a MongoDB instance and Sequelize for support of SQL compatible databases. Mocha is also used for running unit tests in the project.
 
 The resulting API from this project is a JSON REST API which will respond to requests over HTTP. REST Clients can, therefore, connect to the resulting REST server.
 

_config.yml

@@ -0,0 +1 @@
+theme: jekyll-theme-cayman

routes/index.js

@@ -194,6 +194,14 @@ req.cacheKey = key;
 
 };
 
+router.use(helmet());
+router.use(cors());
+router.options('*', cors());
+router.use(bodyParser.urlencoded({ extended: false }));
+router.use(bodyParser.json());
+router.use(bodyParser.raw());
+router.use(bodyParser.text());
+
 // Log requests here
 router.use(function(req,res,next){
   var ipAddress = req.ip;
@@ -222,14 +230,6 @@ queue.create('logRequest', reqLog)
   log.info(reqLog);
   next();
 });
-
-router.use(helmet());
-router.use(cors());
-router.options('*', cors());
-router.use(bodyParser.urlencoded({ extended: false }));
-router.use(bodyParser.json());
-router.use(bodyParser.raw());
-router.use(bodyParser.text());
 // load response handlers
 router.use(response);
 // Watch for encrypted requests
@@ -258,7 +258,7 @@ router.use(expressValidator());
 if(config.noFrontendCaching === 'yes'){
   router.use(helmet.noCache());
 }else{
-   router.use(router._APICache);
+ router.use(router._APICache);
 }
 
 router.get('/', function (req, res) {

services/response/forbidden.js

@@ -22,8 +22,8 @@ module.exports = function(data, message){
 }
 
 if(data){
-  this.status(503).json({status: 'error', data: data, message: message ? message : 'forbidden'});
+  this.status(403).json({status: 'error', data: data, message: message ? message : 'forbidden'});
 }else{
-  this.status(503).json({status: 'error', message: message ? message : 'forbidden'});
+  this.status(403).json({status: 'error', message: message ? message : 'forbidden'});
 }
 };

test/services/response.js

@@ -160,7 +160,7 @@ describe('#Response service test', function(){
     it('should be forbidden', function(done){
         agent.
         get('/forbidden')
-        .expect(503,done);
+        .expect(403,done);
     });
     it('should not be found', function(done){
         agent.