From 18d37d29767945a304960820a0058172a788b9b4 Mon Sep 17 00:00:00 2001
From: Paulo Henrique Santos <paulohs.dev@gmail.com>
Date: Sun, 14 Jul 2019 12:33:52 -0300
Subject: [PATCH] best pratices

Added best pratices and clear code
---
 src/pages/modals/basic/pages.ts | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)

diff --git a/src/pages/modals/basic/pages.ts b/src/pages/modals/basic/pages.ts
index 270cadc0..b9353978 100644
--- a/src/pages/modals/basic/pages.ts
+++ b/src/pages/modals/basic/pages.ts
@@ -1,18 +1,13 @@
 import { Component } from '@angular/core';
-
 import { ModalController, Platform, NavParams, ViewController } from 'ionic-angular';
 
-
 @Component({
   templateUrl: 'template.html'
 })
 export class BasicPage {
-  constructor(public modalCtrl: ModalController) { }
-
-  openModal(characterNum) {
-
-    let modal = this.modalCtrl.create(ModalContentPage, characterNum);
-    modal.present();
+  constructor(private modalCtrl: ModalController) { }
+  openModal(characterNum:number) {
+    this.modalCtrl.create(ModalContentPage, characterNum).present();
   }
 }
 
@@ -53,14 +48,14 @@ export class BasicPage {
 `
 })
 export class ModalContentPage {
-  character;
+  private character:any;
 
   constructor(
-    public platform: Platform,
-    public params: NavParams,
-    public viewCtrl: ViewController
+    private platform: Platform,
+    private params: NavParams,
+    private viewCtrl: ViewController
   ) {
-    var characters = [
+    const characters = [
       {
         name: 'Gollum',
         quote: 'Sneaky little hobbitses!',