Fixed Idea warnings

Author: javadev

src/main/java/com/github/underscore/U.java

@@ -2005,11 +2005,7 @@ public byte[] blob() {
         }
 
         public String text() {
-            try {
-                return stream.toString(StandardCharsets.UTF_8.name());
-            } catch (java.io.UnsupportedEncodingException ex) {
-                throw new UnsupportedOperationException(ex);
-            }
+            return stream.toString(StandardCharsets.UTF_8);
         }
 
         public Object json() {
@@ -3330,7 +3326,7 @@ public Builder add(final String key, final Builder builder) {
         }
 
         public Builder add(final Map<String, Object> map) {
-            deepCopyMap(map).forEach(data::put);
+            data.putAll(deepCopyMap(map));
             return this;
         }
 
@@ -3361,7 +3357,7 @@ public static Builder fromXml(final String xml) {
 
         public static Builder fromMap(final Map<String, Object> map) {
             final Builder builder = new Builder();
-            deepCopyMap(map).forEach(builder.data::put);
+            builder.data.putAll(deepCopyMap(map));
             return builder;
         }
 

src/main/java/com/github/underscore/Underscore.java

@@ -254,7 +254,7 @@ private static final class MyIterable<T> implements Iterable<T> {
         }
 
         public Iterator<T> iterator() {
-            return new Iterator<T>() {
+            return new Iterator<>() {
                 @Override
                 public boolean hasNext() {
                     return true;
@@ -1726,7 +1726,7 @@ public static <T> List<List<T>> unzip(final List<T>... lists) {
     public static <K, V> List<Map.Entry<K, V>> object(final List<K> keys, final List<V> values) {
         return map(
                 keys,
-                new Function<K, Map.Entry<K, V>>() {
+                new Function<>() {
                     private int index;
 
                     @Override
@@ -2065,7 +2065,7 @@ public static <T, F> Function<F, T> bind(final Function<F, T> function) {
      * Documented, #memoize
      */
     public static <T, F> Function<F, T> memoize(final Function<F, T> function) {
-        return new MemoizeFunction<F, T>() {
+        return new MemoizeFunction<>() {
             @Override
             public T calc(F arg) {
                 return function.apply(arg);
@@ -2170,7 +2170,7 @@ public T get() {
      */
     public static <T> Supplier<T> debounce(
             final Supplier<T> function, final int delayMilliseconds) {
-        return new Supplier<T>() {
+        return new Supplier<>() {
             private java.util.concurrent.ScheduledFuture<T> timeout;
 
             @Override
@@ -2262,7 +2262,7 @@ public E get() {
      * Documented, #once
      */
     public static <T> Supplier<T> once(final Supplier<T> function) {
-        return new Supplier<T>() {
+        return new Supplier<>() {
             private volatile boolean executed;
             private T result;
 
@@ -2337,13 +2337,9 @@ public static List<String> methods(final Object object) {
     @SuppressWarnings("unchecked")
     public static <K, V> Map<K, V> extend(final Map<K, V> destination, final Map<K, V>... sources) {
         final Map<K, V> result = newLinkedHashMap();
-        for (final Map.Entry<K, V> entry : destination.entrySet()) {
-            result.put(entry.getKey(), entry.getValue());
-        }
+        result.putAll(destination);
         for (final Map<K, V> source : sources) {
-            for (final Map.Entry<K, V> entry : source.entrySet()) {
-                result.put(entry.getKey(), entry.getValue());
-            }
+            result.putAll(source);
         }
         return result;
     }
@@ -2447,12 +2443,8 @@ public static <K, V> List<Map.Entry<K, V>> omit(
      */
     public static <K, V> Map<K, V> defaults(final Map<K, V> object, final Map<K, V> defaults) {
         final Map<K, V> result = newLinkedHashMap();
-        for (final Map.Entry<K, V> entry : defaults.entrySet()) {
-            result.put(entry.getKey(), entry.getValue());
-        }
-        for (final Map.Entry<K, V> entry : object.entrySet()) {
-            result.put(entry.getKey(), entry.getValue());
-        }
+        result.putAll(defaults);
+        result.putAll(object);
         return result;
     }
 

src/main/java/com/github/underscore/Xml.java

@@ -142,9 +142,8 @@ public XmlStringBuilder append(final String string) {
         }
 
         public XmlStringBuilder fillSpaces() {
-            for (int index = 0; index < ident; index += 1) {
-                builder.append(identStep == Step.TABS ? '\t' : ' ');
-            }
+            builder.append(
+                    String.valueOf(identStep == Step.TABS ? '\t' : ' ').repeat(Math.max(0, ident)));
             return this;
         }
 
@@ -1053,9 +1052,7 @@ private static void escape(String s, StringBuilder sb) {
                                 || ch >= '\u2000' && ch <= '\u20FF') {
                             String ss = Integer.toHexString(ch);
                             sb.append("&#x");
-                            for (int k = 0; k < 4 - ss.length(); k++) {
-                                sb.append('0');
-                            }
+                            sb.append("0".repeat(4 - ss.length()));
                             sb.append(ss.toUpperCase()).append(";");
                         } else {
                             sb.append(ch);

src/test/java/com/github/underscore/LodashTest.java

@@ -685,19 +685,6 @@ void fetchGetXml() {
         assertEquals("Tove", U.get(result.xmlMap(), "note.to"));
     }
 
-    @Test
-    void fetchResponseError() {
-        java.io.ByteArrayOutputStream stream =
-                new java.io.ByteArrayOutputStream() {
-                    public String toString(String encoding)
-                            throws java.io.UnsupportedEncodingException {
-                        throw new java.io.UnsupportedEncodingException();
-                    }
-                };
-        U.FetchResponse fetchResponse = new U.FetchResponse(true, 100, null, stream);
-        assertThrows(UnsupportedOperationException.class, () -> fetchResponse.text());
-    }
-
     @Test
     void fetchResponseBlob() {
         java.io.ByteArrayOutputStream stream = new java.io.ByteArrayOutputStream();