Skip to content
This repository was archived by the owner on Jul 2, 2024. It is now read-only.

Commit e6a1763

Browse files
committed
ISSUE 245: Changes DOCKER_CONTAINER_PARAMETERS_APPEND to DOCKER_CONTAINER_OPTS for usability.
1 parent 7c89dd0 commit e6a1763

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ create: prerequisites require-docker-container-not
8888
$(docker) create \
8989
$(DOCKER_CONTAINER_PARAMETERS) \
9090
$(DOCKER_PUBLISH) \
91-
$(DOCKER_CONTAINER_PARAMETERS_APPEND) \
91+
$(DOCKER_CONTAINER_OPTS) \
9292
$(DOCKER_USER)/$(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_TAG) 1> /dev/null;
9393
@ if [[ -n $$($(docker) ps -aq --filter "name=$(DOCKER_NAME)" --filter "status=created") ]]; then \
9494
echo "$(PREFIX_SUB_STEP) $$($(docker) ps -aq --filter "name=$(DOCKER_NAME)" --filter "status=created")"; \
@@ -325,7 +325,7 @@ run: prerequisites require-docker-image-tag
325325
--detach \
326326
$(DOCKER_CONTAINER_PARAMETERS) \
327327
$(DOCKER_PUBLISH) \
328-
$(DOCKER_CONTAINER_PARAMETERS_APPEND) \
328+
$(DOCKER_CONTAINER_OPTS) \
329329
$(DOCKER_USER)/$(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_TAG) 1> /dev/null;
330330
@ if [[ -n $$($(docker) ps -aq --filter "name=$(DOCKER_NAME)" --filter "status=running") ]]; then \
331331
echo "$(PREFIX_SUB_STEP) $$($(docker) ps -aq --filter "name=$(DOCKER_NAME)" --filter "status=running")"; \

environment.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ DOCKER_IMAGE_RELEASE_TAG_PATTERN := ^centos-(6-1|7-2).[0-9]+.[0-9]+$
1313
# -----------------------------------------------------------------------------
1414

1515
# Docker image/container settings
16-
DOCKER_CONTAINER_PARAMETERS_APPEND ?=
16+
DOCKER_CONTAINER_OPTS ?=
1717
DOCKER_IMAGE_TAG ?= latest
1818
DOCKER_NAME ?= apache-php.pool-1.1.1
1919
DOCKER_PORT_MAP_TCP_22 ?= NULL

etc/systemd/system/centos-ssh-apache-php-fcgi@.service

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ Restart=on-failure
4949
RestartSec=30
5050
TimeoutStartSec=1200
5151
Environment="DOCKER_USER=jdeathe"
52-
Environment="DOCKER_CONTAINER_PARAMETERS_APPEND="
52+
Environment="DOCKER_CONTAINER_OPTS="
5353
Environment="DOCKER_IMAGE_PACKAGE_PATH=/var/opt/scmi/packages"
5454
Environment="DOCKER_IMAGE_NAME=centos-ssh-apache-php-fcgi"
5555
Environment="DOCKER_IMAGE_TAG=centos-6-1.7.1"
@@ -158,7 +158,7 @@ ExecStart=/bin/bash -c \
158158
--env \"APACHE_SERVER_NAME=${APACHE_SERVER_NAME}\" \
159159
--env \"APACHE_SYSTEM_USER=${APACHE_SYSTEM_USER}\" \
160160
--env \"PHP_OPTIONS_DATE_TIMEZONE=${PHP_OPTIONS_DATE_TIMEZONE}\" \
161-
${DOCKER_CONTAINER_PARAMETERS_APPEND} \
161+
${DOCKER_CONTAINER_OPTS} \
162162
${DOCKER_USER}/${DOCKER_IMAGE_NAME}:${DOCKER_IMAGE_TAG}; \
163163
"
164164

opt/scmi/environment.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ DOCKER_IMAGE_RELEASE_TAG_PATTERN='^centos-(6-1|7-2).[0-9]+.[0-9]+$'
1313
# -----------------------------------------------------------------------------
1414

1515
# Docker image/container settings
16-
DOCKER_CONTAINER_PARAMETERS_APPEND="${DOCKER_CONTAINER_PARAMETERS_APPEND:-}"
16+
DOCKER_CONTAINER_OPTS="${DOCKER_CONTAINER_OPTS:-}"
1717
DOCKER_IMAGE_TAG="${DOCKER_IMAGE_TAG:-latest}"
1818
DOCKER_NAME="${DOCKER_NAME:-apache-php.pool-1.1.1}"
1919
DOCKER_PORT_MAP_TCP_22="${DOCKER_PORT_MAP_TCP_22:-NULL}"

0 commit comments

Comments
 (0)