Solutions for providing the -warn-error argument to rescript build

[benadamstyles]

We use -warn-error +32+27+26+110 (see docs) when building for production, so that during dev we can have unused variables but disallow them for production builds.

I'd like to make a PR to add support for this, I can think of 2 options:

1. Add config to this plugin to pass args to the rescript command.
2. Add config to this plugin to explicitly skip the rescript build, so that we can run it ourselves first without the plugin then running it again.

Do you have a preference, are there other options I haven't thought of, or can we already achieve what we need without any changes to the plugin?

Thanks!

[jihchi]

Hi @benadamstyles, Thanks for the ticket and proposal. It's interesting to learn more about how people use ReScript.

Option 1 looks more suitable to me. It might be useful to configure arguments based on build type (development or production).

[benadamstyles]

Thanks for the quick reply! Thinking about it more, I think there would be a lot of value in option 2. Being able to run the compiler separately (e.g. in a separate terminal) would help with terminal output noise too. And it would be more future-proof in the sense that it would allow alternative compiler commands, even alternative compiler binaries to be used. It would essentially decouple this plugin from the rescript binary which would mean you wouldn't need to update the plugin every time the compiler commands change.

If I make a PR adding a skipBuild config option, would you accept it? Are there corner cases I haven't thought of?

[benadamstyles]

@jihchi Sorry for the noise, I changed my mind and went with option 1 😅 #281

[jihchi]

@benadamstyles No worries! Thank you for the PR.

Regarding the versioning, I propose to create a dedicated v7 branch based on v7.1.0 so that the feature can be included in both v7 and v8. Does this work for you?

[benadamstyles]

@jihchi Absolutely it does, thanks so much!