[Fix] : fix crash on for...of destructuring

yannickcr · yannickcr · commit 057f1db2442a · 2019-06-24T18:08:04.000+02:00
Fixes #2326
diff --git a/lib/util/usedPropTypes.js b/lib/util/usedPropTypes.js
@@ -452,7 +452,7 @@ module.exports = function usedPropTypesInstructions(context, components, utils)
       }
 
       // Only handles destructuring
-      if (node.id.type !== 'ObjectPattern') {
+      if (node.id.type !== 'ObjectPattern' || !node.init) {
         return;
       }
 
diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -2349,6 +2349,12 @@ ruleTester.run('prop-types', rule, {
       }
       `,
       parser: parsers.BABEL_ESLINT
+    },
+    {
+      // issue #2326
+      code: `
+        for (const {result} of results) {}
+      `
     }
   ],
 

Original file line number	Diff line number	Diff line change
`@@ -452,7 +452,7 @@ module.exports = function usedPropTypesInstructions(context, components, utils)`
`452`	`452`	`}`
`453`	`453`
`454`	`454`	`// Only handles destructuring`
`455`		`- if (node.id.type !== 'ObjectPattern') {`
	`455`	`+ if (node.id.type !== 'ObjectPattern' \|\| !node.init) {`
`456`	`456`	`return;`
`457`	`457`	`}`
`458`	`458`
Original file line number	Diff line number	Diff line change
`@@ -2349,6 +2349,12 @@ ruleTester.run('prop-types', rule, {`
`2349`	`2349`	`}`
`2350`	`2350`	`,
`2351`	`2351`	`parser: parsers.BABEL_ESLINT`
	`2352`	`+ },`
	`2353`	`+ {`
	`2354`	`+ // issue #2326`
	`2355`	+ code: `
	`2356`	`+ for (const {result} of results) {}`
	`2357`	+ `
`2352`	`2358`	`}`
`2353`	`2359`	`],`
`2354`	`2360`