Fix sort-prop-types crash with spread operator (fixes #478)

Author: yannickcr

docs/rules/sort-prop-types.md

@@ -4,9 +4,7 @@ Some developers prefer to sort propTypes declarations alphabetically to be able
 
 ## Rule Details
 
-This rule checks all components and verifies that all propTypes declarations are sorted alphabetically.
-The default configuration of the rule is case-sensitive.
-This rule is off by default.
+This rule checks all components and verifies that all propTypes declarations are sorted alphabetically. A spread attribute resets the verification. The default configuration of the rule is case-sensitive.
 
 The following patterns are considered warnings:
 

lib/rules/sort-prop-types.js

@@ -9,6 +9,7 @@
 
 module.exports = function(context) {
 
+  var sourceCode = context.getSourceCode();
   var configuration = context.options[0] || {};
   var requiredFirst = configuration.requiredFirst || false;
   var callbacksLast = configuration.callbacksLast || false;
@@ -36,11 +37,11 @@ module.exports = function(context) {
   }
 
   function getKey(node) {
-    return node.key.type === 'Identifier' ? node.key.name : node.key.value;
+    return sourceCode.getText(node.key || node.argument);
   }
 
   function getValueName(node) {
-    return node.value.property && node.value.property.name;
+    return node.type === 'Property' && node.value.property && node.value.property.name;
   }
 
   function isCallbackPropName(propName) {
@@ -57,7 +58,11 @@ module.exports = function(context) {
    * @returns {void}
    */
   function checkSorted(declarations) {
-    declarations.reduce(function(prev, curr) {
+    declarations.reduce(function(prev, curr, idx, decls) {
+      if (/SpreadProperty$/.test(curr.type)) {
+        return decls[idx + 1];
+      }
+
       var prevPropName = getKey(prev);
       var currentPropName = getKey(curr);
       var previousIsRequired = isRequiredProp(prev);

tests/lib/rules/sort-prop-types.js

@@ -312,6 +312,17 @@ ruleTester.run('sort-prop-types', rule, {
       callbacksLast: true
     }],
     parserOptions: parserOptions
+  }, {
+    code: [
+      'export default class ClassWithSpreadInPropTypes extends BaseClass {',
+      '  static propTypes = {',
+      '    b: PropTypes.string,',
+      '    ...c.propTypes,',
+      '    a: PropTypes.string',
+      '  }',
+      '}'
+    ].join('\n'),
+    parser: 'babel-eslint'
   }],
 
   invalid: [{
@@ -595,5 +606,23 @@ ruleTester.run('sort-prop-types', rule, {
       column: 5,
       type: 'Property'
     }]
+  }, {
+    code: [
+      'export default class ClassWithSpreadInPropTypes extends BaseClass {',
+      '  static propTypes = {',
+      '    b: PropTypes.string,',
+      '    ...a.propTypes,',
+      '    d: PropTypes.string,',
+      '    c: PropTypes.string',
+      '  }',
+      '}'
+    ].join('\n'),
+    parser: 'babel-eslint',
+    errors: [{
+      message: 'Prop types declarations should be sorted alphabetically',
+      line: 6,
+      column: 5,
+      type: 'Property'
+    }]
   }]
 });