feat(jsx-key): check for array related method calls with jsx elements/fragments

Author: SimonSchick

lib/rules/jsx-key.js

@@ -263,6 +263,25 @@ module.exports = {
         }
       },
 
+      // eslint-disable-next-line no-multi-str
+      'CallExpression[callee.type="MemberExpression"][callee.property.name=/^push|unshift|splice|with$/],\
+       CallExpression[callee.type="OptionalMemberExpression"][callee.property.name=/^push|unshift|splice|with$/],\
+       OptionalCallExpression[callee.type="MemberExpression"][callee.property.name=/^push|unshift|splice|with$/],\
+       OptionalCallExpression[callee.type="OptionalMemberExpression"][callee.property.name=/^push|unshift|splice|with$/]'(node) {
+        if (node.arguments.length === 0) {
+          return;
+        }
+
+        node.arguments.forEach((arg) => {
+          if (arg.type === 'JSXElement' && !hasProp(arg.openingElement.attributes, 'key')) {
+            report(context, messages.missingIterKey, 'missingArrayKey', { node });
+          }
+          if (arg.type === 'JSXFragment') {
+            report(context, messages.missingIterKey, 'missingArrayKeyUsePrag', { node });
+          }
+        });
+      },
+
       // Array.prototype.map
       // eslint-disable-next-line no-multi-str
       'CallExpression[callee.type="MemberExpression"][callee.property.name="map"],\

tests/lib/rules/jsx-key.js

@@ -205,6 +205,12 @@ ruleTester.run('jsx-key', rule, {
       `,
       settings,
     },
+    {
+      code: 'arr.push(<App key="key" />);',
+    },
+    {
+      code: 'arr.push(<React.Fragment key="key" />);',
+    },
   ]),
   invalid: parsers.all([
     {
@@ -424,5 +430,13 @@ ruleTester.run('jsx-key', rule, {
       options: [{ checkKeyMustBeforeSpread: true }],
       errors: [{ messageId: 'keyBeforeSpread' }],
     },
+    {
+      code: 'arr.push(<App />);',
+      errors: [{ messageId: 'missingArrayKey' }],
+    },
+    {
+      code: 'arr.push(<></>);',
+      errors: [{ messageId: 'missingArrayKeyUsePrag' }],
+    },
   ]),
 });