Fix prop-types crash (fixes #389)

Author: yannickcr

lib/rules/prop-types.js

@@ -272,6 +272,7 @@ module.exports = Components.detect(function(context, components, utils) {
     }
 
     if (
+      value &&
       value.type === 'MemberExpression' &&
       value.property &&
       value.property.name &&
@@ -282,6 +283,7 @@ module.exports = Components.detect(function(context, components, utils) {
 
     // Verify React.PropTypes that are functions
     if (
+      value &&
       value.type === 'CallExpression' &&
       value.callee &&
       value.callee.property &&
@@ -597,6 +599,10 @@ module.exports = Components.detect(function(context, components, utils) {
         break;
       case 'ObjectExpression':
         iterateProperties(propTypes.properties, function(key, value) {
+          if (!value) {
+            ignorePropsValidation = true;
+            return;
+          }
           declaredPropTypes[key] = buildReactDeclarationTypes(value);
         });
         break;

tests/lib/rules/prop-types.js

@@ -1021,6 +1021,23 @@ ruleTester.run('prop-types', rule, {
         '}'
       ].join('\n'),
       parser: 'babel-eslint'
+    }, {
+      // Ignore component validation if propTypes are composed using spread
+      code: [
+        'class Hello extends React.Component {',
+        '    render() {',
+        '        return  <div>Hello {this.props.firstName} {this.props.lastName}</div>;',
+        '    }',
+        '};',
+        'const otherPropTypes = {',
+        '    lastName: React.PropTypes.string',
+        '};',
+        'Hello.propTypes = {',
+        '    ...otherPropTypes,',
+        '    firstName: React.PropTypes.string',
+        '};'
+      ].join('\n'),
+      parserOptions: parserOptions
     }
   ],