Fix no-unknown-property check on SVG attributes (fixes #718)

Author: yannickcr

lib/rules/no-unknown-property.js

@@ -4,8 +4,6 @@
  */
 'use strict';
 
-var versionUtil = require('../util/version');
-
 // ------------------------------------------------------------------------------
 // Constants
 // ------------------------------------------------------------------------------
@@ -94,16 +92,14 @@ function isTagName(node) {
 
 /**
  * Get the standard name of the attribute.
- * @param {Object} context The current rule context.
  * @param {String} name - Name of the attribute.
  * @returns {String} The standard name of the attribute.
  */
-function getStandardName(context, name) {
+function getStandardName(name) {
   if (DOM_ATTRIBUTE_NAMES[name]) {
     return DOM_ATTRIBUTE_NAMES[name];
   }
-  // Also check for SVG attribute for React <15
-  if (!versionUtil.test(context, '15.0.0') && SVGDOM_ATTRIBUTE_NAMES[name]) {
+  if (SVGDOM_ATTRIBUTE_NAMES[name]) {
     return SVGDOM_ATTRIBUTE_NAMES[name];
   }
   var i;
@@ -150,7 +146,7 @@ module.exports = {
       JSXAttribute: function(node) {
         var ignoreNames = getIgnoreConfig();
         var name = sourceCode.getText(node.name);
-        var standardName = getStandardName(context, name);
+        var standardName = getStandardName(name);
         if (!isTagName(node) || !standardName || ignoreNames.indexOf(name) >= 0) {
           return;
         }

tests/lib/rules/no-unknown-property.js

@@ -36,9 +36,7 @@ ruleTester.run('no-unknown-property', rule, {
     {code: '<div data-foo="bar"></div>;', parserOptions: parserOptions},
     {code: '<div class="foo" is="my-elem"></div>;', parserOptions: parserOptions},
     {code: '<div {...this.props} class="foo" is="my-elem"></div>;', parserOptions: parserOptions},
-    {code: '<atom-panel class="foo"></atom-panel>;', parserOptions: parserOptions},
-    {code: '<use xlink:href="bar" />;', parserOptions: parserOptions},
-    {code: '<rect clip-path="bar" />;', parserOptions: parserOptions}, {
+    {code: '<atom-panel class="foo"></atom-panel>;', parserOptions: parserOptions}, {
       code: '<div class="bar"></div>;',
       options: [{ignore: ['class']}],
       parserOptions: parserOptions
@@ -83,21 +81,11 @@ ruleTester.run('no-unknown-property', rule, {
     code: '<use xlink:href="bar" />;',
     output: '<use xlinkHref="bar" />;',
     errors: [{message: 'Unknown property \'xlink:href\' found, use \'xlinkHref\' instead'}],
-    parserOptions: parserOptions,
-    settings: {
-      react: {
-        version: '0.14.0'
-      }
-    }
+    parserOptions: parserOptions
   }, {
     code: '<rect clip-path="bar" />;',
     output: '<rect clipPath="bar" />;',
     errors: [{message: 'Unknown property \'clip-path\' found, use \'clipPath\' instead'}],
-    parserOptions: parserOptions,
-    settings: {
-      react: {
-        version: '0.14.0'
-      }
-    }
+    parserOptions: parserOptions
   }]
 });