Fix sort-comp crash on stateless components (fixes #285)

Author: yannickcr

lib/rules/sort-comp.js

@@ -75,18 +75,6 @@ module.exports = Components.detect(function(context, components) {
     }
   }, context.options[0]);
 
-  /**
-   * Checks if the component must be validated
-   * @param {Object} component The component to process
-   * @returns {Boolean} True if the component must be validated, false if not.
-   */
-  function mustBeValidated(component) {
-    return (
-      component &&
-      !component.hasDisplayName
-    );
-  }
-
   // --------------------------------------------------------------------------
   // Public
   // --------------------------------------------------------------------------
@@ -236,10 +224,14 @@ module.exports = Components.detect(function(context, components) {
    * @returns {Array} Properties array.
    */
   function getComponentProperties(node) {
-    if (node.type === 'ClassDeclaration') {
-      return node.body.body;
+    switch (node.type) {
+      case 'ClassDeclaration':
+        return node.body.body;
+      case 'ObjectExpression':
+        return node.properties;
+      default:
+        return [];
     }
-    return node.properties;
   }
 
   /**
@@ -346,7 +338,7 @@ module.exports = Components.detect(function(context, components) {
     'Program:exit': function() {
       var list = components.list();
       for (var component in list) {
-        if (!list.hasOwnProperty(component) || !mustBeValidated(list[component])) {
+        if (!list.hasOwnProperty(component)) {
           continue;
         }
         var properties = getComponentProperties(list[component].node);

tests/lib/rules/sort-comp.js

@@ -189,6 +189,22 @@ ruleTester.run('sort-comp', rule, {
       classes: true,
       jsx: true
     }
+  }, {
+    // Must ignore stateless components
+    code: [
+      'function Hello(props) {',
+      '  return <div>Hello {props.name}</div>',
+      '}'
+    ].join('\n'),
+    parser: 'babel-eslint'
+  }, {
+    // Must ignore stateless components (arrow function with explicit return)
+    code: [
+      'var Hello = props => (',
+      '  <div>Hello {props.name}</div>',
+      ')'
+    ].join('\n'),
+    parser: 'babel-eslint'
   }],
 
   invalid: [{