Fix component detection (fixes #144)

Author: Yannick Croissant

lib/rules/prop-types.js

@@ -78,7 +78,7 @@ module.exports = function(context) {
    * @returns {Boolean} True if the component must be validated, false if not.
    */
   function mustBeValidated(component) {
-    return (
+    return Boolean(
       component &&
       component.isReactComponent &&
       component.usedPropTypes &&

lib/util/component.js

@@ -22,6 +22,10 @@ function isReactComponent(context, node) {
   }
 
   var scope = context.getScope();
+  while (scope.upper && scope.type !== 'function') {
+    scope = scope.upper;
+  }
+
   var isComponentRender =
     node.argument &&
     node.argument.type === 'JSXElement' &&

tests/lib/rules/prop-types.js

@@ -955,6 +955,25 @@ eslintTester.addRuleTest('lib/rules/prop-types', {
       errors: [
         {message: '\'firstname\' is missing in props validation for Hello'}
       ]
+    }, {
+      code: [
+        'class Hello extends React.Component {',
+        '  render() {',
+        '    if (true) {',
+        '      return <span>{this.props.firstname}</span>',
+        '    } else {',
+        '      return <span>{this.props.lastname}</span>',
+        '    }',
+        '  }',
+        '}',
+        'Hello.propTypes = {',
+        '  lastname: React.PropTypes.string',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint',
+      errors: [
+        {message: '\'firstname\' is missing in props validation for Hello'}
+      ]
     }
   ]
 });