[patch] no-deprecated: report on the destructured property instead of the entire variable declarator

This also makes error ordering more consistent since certain eslint/node combinations reverse the ordering

Author: ljharb

CHANGELOG.md

@@ -8,6 +8,7 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 ### Fixed
 * [`no-deprecated`]: prevent false positive on commonjs import ([#3614][] @akulsr0)
 * [`no-unsafe`]: report on the method instead of the entire component (@ljharb)
+* [`no-deprecated`]: report on the destructured property instead of the entire variable declarator (@ljharb)
 
 [#3614]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3614
 

lib/rules/no-deprecated.js

@@ -246,7 +246,7 @@ module.exports = {
           return;
         }
         node.id.properties.filter((p) => p.type !== 'RestElement' && p.key).forEach((property) => {
-          checkDeprecation(node, `${reactModuleName || pragma}.${property.key.name}`);
+          checkDeprecation(node, `${reactModuleName || pragma}.${property.key.name}`, property);
         });
       },
 

tests/lib/rules/no-deprecated.js

@@ -236,14 +236,14 @@ ruleTester.run('no-deprecated', rule, {
           '15.5.0',
           'the npm module create-react-class',
           null,
-          { type: 'VariableDeclarator', column: 5 }
+          { type: 'Property', column: 6 }
         ),
         errorMessage(
           'React.PropTypes',
           '15.5.0',
           'the npm module prop-types',
           null,
-          { type: 'VariableDeclarator', column: 5 }
+          { type: 'Property', column: 19 }
         ),
       ],
     },
@@ -269,14 +269,14 @@ ruleTester.run('no-deprecated', rule, {
           '15.5.0',
           'the npm module create-react-class',
           null,
-          { type: 'VariableDeclarator', line: 3, column: 13 }
+          { type: 'Property', line: 3, column: 14 }
         ),
         errorMessage(
           'React.PropTypes',
           '15.5.0',
           'the npm module prop-types',
           null,
-          { type: 'VariableDeclarator', line: 3, column: 13 }
+          { type: 'Property', line: 3, column: 27 }
         ),
       ],
     },