Fixes

Author: blegat

src/Bridges/Bridges.jl

@@ -307,11 +307,12 @@ function _test_dual(
     Bridge::Type{<:AbstractBridge},
     input_fn::Function;
     dual,
+    eltype,
     model_eltype,
 )
     inner = MOI.Utilities.UniversalFallback(MOI.Utilities.Model{model_eltype}())
     mock = MOI.Utilities.MockOptimizer(inner)
-    model = _bridged_model(Bridge{model_eltype}, mock)
+    model = _bridged_model(Bridge{eltype}, mock)
     input_fn(model)
     final_touch(model)
     # Should be able to call final_touch multiple times.
@@ -331,17 +332,21 @@ function _test_dual(
             MOI.set(model, MOI.ConstraintDual(), ci, _fake_start(dual, set))
         end
     end
-    model_dual = MOI.Utilities.get_fallback(
-        model,
-        MOI.DualObjectiveValue(),
-        model_eltype,
-    )
+    model_dual =
+        MOI.Utilities.get_fallback(model, MOI.DualObjectiveValue(), eltype)
     mock_dual =
-        MOI.Utilities.get_fallback(mock, MOI.DualObjectiveValue(), model_eltype)
+        MOI.Utilities.get_fallback(mock, MOI.DualObjectiveValue(), eltype)
     # Need `atol` in case one of them is zero and the other one almost zero
     Test.@test model_dual ≈ mock_dual atol = 1e-6
 end
 
+function _check_bridged(model; no_bridge_used)
+    unused = isempty(MOI.Bridges.Variable.bridges(model)) &&
+        isempty(MOI.Bridges.Constraint.bridges(model)) &&
+        isempty(MOI.Bridges.Objective.bridges(model))
+    Test.@test unused == no_bridge_used
+end
+
 function _runtests(
     Bridge::Type{<:AbstractBridge},
     input_fn::Function,
@@ -353,17 +358,22 @@ function _runtests(
     model_eltype = eltype,
     print_inner_model::Bool = false,
     cannot_unbridge::Bool = false,
+    no_bridge_used::Bool = false,
 )
     # Load model and bridge it
     inner = MOI.Utilities.UniversalFallback(MOI.Utilities.Model{model_eltype}())
     model = _bridged_model(Bridge{eltype}, inner)
     input_fn(model)
+    _check_bridged(model; no_bridge_used)
     final_touch(model)
     # Should be able to call final_touch multiple times.
     final_touch(model)
     if print_inner_model
         print(inner)
     end
+    if no_bridge_used
+        return
+    end
     Test.@testset "Test outer bridged model appears like the input" begin       # COV_EXCL_LINE
         test =
             MOI.Utilities.UniversalFallback(MOI.Utilities.Model{model_eltype}())
@@ -455,7 +465,7 @@ function _runtests(
     end
     if !isnothing(dual)
         Test.@testset "Test ConstraintDual" begin
-            _test_dual(Bridge, input_fn; dual, model_eltype)
+            _test_dual(Bridge, input_fn; dual, eltype, model_eltype)
         end
     end
     return

src/Utilities/results.jl

@@ -88,9 +88,14 @@ function _dual_objective_value(
     )
 end
 
+_lower(set::MOI.Interval, ::Type) = set.lower
+_upper(set::MOI.Interval, ::Type) = set.upper
+_lower(::MOI.ZeroOne, ::Type{T}) where {T} = zero(T)
+_upper(::MOI.ZeroOne, ::Type{T}) where {T} = one(T)
+
 function _dual_objective_value(
     model::MOI.ModelLike,
-    ci::MOI.ConstraintIndex{<:MOI.AbstractScalarFunction,<:MOI.Interval},
+    ci::MOI.ConstraintIndex{<:MOI.AbstractScalarFunction,<:Union{MOI.ZeroOne,MOI.Interval}},
     ::Type{T},
     result_index::Integer,
 ) where {T}
@@ -100,10 +105,10 @@ function _dual_objective_value(
     if dual < zero(dual)
         # The dual is negative so it is in the dual of the MOI.LessThan cone
         # hence the upper bound of the Interval set is tight
-        constant -= set.upper
+        constant -= _upper(set, T)
     else
         # the lower bound is tight
-        constant -= set.lower
+        constant -= _lower(set, T)
     end
     return set_dot(constant, dual, set)
 end

test/Bridges/Constraint/IndicatorSOS1Bridge.jl

@@ -345,6 +345,7 @@ function test_runtests()
         [z, 2.0 * x * x] in Indicator{ACTIVATE_ON_ONE}(LessThan(2.0))
         z in ZeroOne()
         """,
+        no_bridge_used = true,
     )
     return
 end

test/Bridges/Constraint/NumberConversionBridge.jl

@@ -104,6 +104,7 @@ function test_runtests()
         variables: x
         ::Float64: [x, x] in Zeros(2)
         """,
+        no_bridge_used = true,
     )
     # VectorAffineFunction
     MOI.Bridges.runtests(

test/Bridges/Constraint/ScalarFunctionizeBridge.jl

@@ -317,6 +317,7 @@ function test_FunctionConversionBridge()
         variables: x, y
         ScalarNonlinearFunction(1.0 * x * x + 2.0 * x * y + 3.0 * y + 4.0) >= 1.0
         """,
+        dual = nothing, # `get_fallback` ignores the constant `4.0` of the function
     )
     # VectorAffineFunction -> VectorQuadraticFunction
     MOI.Bridges.runtests(