Skip to content

Making right pane editable and update source on changes. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Making right pane editable and update source on changes. #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/diff/cell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,16 @@ class CodeMirrorSplitDiffWidget extends BaseDiffWidget {
extensions: [
basicSetup,
python(),
EditorView.editable.of(false),
jupyterTheme
EditorView.editable.of(true),
jupyterTheme,
EditorView.updateListener.of(update => {
if (update.docChanged) {
const newText = update.state.doc.toString();

this._modifiedCode = newText;
this._newSource = newText;
}
})
]
},
parent: this.node
Expand Down
4 changes: 2 additions & 2 deletions src/widget.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export abstract class BaseDiffWidget extends Widget {
*/
public onAcceptClick(): void {
if (this._cell) {
this._cell.sharedModel.setSource(this._newSource);
this._cell.sharedModel.setSource(this._newSource || this._originalSource);
this._closeDiffView();
}
}
Expand Down Expand Up @@ -191,9 +191,9 @@ export abstract class BaseDiffWidget extends Widget {
private _cell: ICellModel;
private _cellFooterTracker: ICellFooterTracker;
private _originalSource: string;
private _newSource: string;
private _showActionButtons: boolean;
private _openDiff: boolean;
private _toggleButton: ToolbarButton | null = null;
private _trans: TranslationBundle;
public _newSource: string;
}
Loading