Skip to content

Try to import bdist_wheel from setuptools first #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bnavigator wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Try to import bdist_wheel from setuptools first #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47614d5
Try to import bdist_wheel from setuptools first
bnavigator Sep 16, 2024
4992060
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 16, 2024
b565482
Ignore wheel warning
bnavigator Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions jupyter_packaging/setupbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,12 @@
from setuptools.command.sdist import sdist

try:
from wheel.bdist_wheel import bdist_wheel
from setuptools.command.bdist_wheel import bdist_wheel
except ImportError: # pragma: no cover
bdist_wheel = None
try:
from wheel.bdist_wheel import bdist_wheel
except ImportError:
bdist_wheel = None

if sys.platform == "win32": # pragma: no cover
from subprocess import list2cmdline
Expand Down
5 changes: 4 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,5 +80,8 @@ filterwarnings= [
# Ignore our own deprecation warnings.
"ignore:.*:deprecation.DeprecatedWarning",
# Ignore warning raised when importing setuptools.command.develop.
"ignore:pkg_resources is deprecated as an API:DeprecationWarning"
"ignore:pkg_resources is deprecated as an API:DeprecationWarning",
# bdist_wheel moved from wheel 0.44+ to setuptools 0.70.1+.
# We already handle it but wheel 0.44 could still emit the warning with an older setuptools.
"ignore:The 'wheel' package is no longer the canonical location of the 'bdist_wheel' command:DeprecationWarning",
]