storage deletion logic

Author: sp-yduck

cloud/services/compute/storage/reconcile.go

@@ -28,7 +28,10 @@ func (s *Service) Reconcile(ctx context.Context) error {
 }
 
 func (s *Service) Delete(ctx context.Context) error {
-	// to do
+	// return s.deleteStorage(ctx)
+	// not worthy to delete Storage
+	// since deleting Storage will block vm deletion
+	// and does not delete actual content in the node
 	return nil
 }
 
@@ -62,6 +65,26 @@ func (s *Service) createStorage(options storage.StorageCreateOptions) error {
 	return nil
 }
 
+func (s *Service) deleteStorage(ctx context.Context) error {
+	log := log.FromContext(ctx)
+	nodes, err := s.client.Nodes()
+	if err != nil {
+		return err
+	}
+	for _, node := range nodes {
+		storage, err := node.Storage(s.scope.Storage().Name)
+		if err != nil {
+			log.Info(err.Error())
+			continue
+		}
+		if _, err := storage.Delete(); err != nil {
+			log.Info(err.Error())
+			return err
+		}
+	}
+	return nil
+}
+
 func generateVMStorageOptions(scope Scope) storage.StorageCreateOptions {
 	storageSpec := scope.Storage()
 	options := storage.StorageCreateOptions{

controllers/proxmoxcluster_controller.go

@@ -144,7 +144,7 @@ func (r *ProxmoxClusterReconciler) reconcileDelete(ctx context.Context, clusterS
 	log.Info("Reconciling Delete ProxmoxCluster")
 
 	reconcilers := []cloud.Reconciler{
-		// to do
+		storage.NewService(clusterScope),
 	}
 
 	for _, r := range reconcilers {