Get parent lock before creating inode from Goofys.MkDir or Goofys.CreateFile to avoid creating a duplicate inode.

Remove get lock from `Inode.Create` and `Inode.MkDir` since it lock already acquired by the caller.

Author: skuppa

internal/dir.go

@@ -905,9 +905,6 @@ func (parent *Inode) Create(
 
 	fs := parent.fs
 
-	parent.mu.Lock()
-	defer parent.mu.Unlock()
-
 	now := time.Now()
 	inode = NewInode(fs, parent, &name)
 	inode.Attributes = InodeAttributes{
@@ -948,9 +945,6 @@ func (parent *Inode) MkDir(
 		return
 	}
 
-	parent.mu.Lock()
-	defer parent.mu.Unlock()
-
 	inode = NewInode(fs, parent, &name)
 	inode.ToDir()
 	inode.touch()

internal/goofys.go

@@ -1013,10 +1013,10 @@ func (fs *Goofys) CreateFile(
 	parent := fs.getInodeOrDie(op.Parent)
 	fs.mu.RUnlock()
 
-	inode, fh := parent.Create(op.Name, op.Metadata)
-
 	parent.mu.Lock()
 
+	inode, fh := parent.Create(op.Name, op.Metadata)
+
 	fs.mu.Lock()
 	defer fs.mu.Unlock()
 	fs.insertInode(parent, inode)
@@ -1046,17 +1046,21 @@ func (fs *Goofys) MkDir(
 	op *fuseops.MkDirOp) (err error) {
 
 	fs.mu.RLock()
-	defer fs.mu.RUnlock()
 	parent := fs.getInodeOrDie(op.Parent)
+	fs.mu.RUnlock()
+
+	parent.mu.Lock()
 
 	// ignore op.Mode for now
 	inode, err := parent.MkDir(op.Name)
 	if err != nil {
 		return err
 	}
 
-	parent.mu.Lock()
+	fs.mu.Lock()
+	defer fs.mu.Unlock()
 	fs.insertInode(parent, inode)
+
 	parent.mu.Unlock()
 
 	op.Entry.Child = inode.Id