Skip to content

Commit 77a827c

Browse files
committed
Ignore case on query by first name and sort by first and then last name ascending
1 parent 05e2be9 commit 77a827c

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

src/main/java/com/madadipouya/springkafkatest/repository/UserRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@
99
@Repository
1010
public interface UserRepository extends JpaRepository<User, String> {
1111

12-
List<User> getByFirstName(String firstName);
12+
List<User> getByFirstNameIgnoreCaseOrderByFirstNameAscLastNameAsc(String firstName);
1313

1414
}

src/main/java/com/madadipouya/springkafkatest/service/impl/DefaultUserService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,6 @@ public void save(User user) {
2828

2929
@Override
3030
public List<com.madadipouya.springkafkatest.entity.User> getUsers(String firstName) {
31-
return userRepository.getByFirstName(firstName);
31+
return userRepository.getByFirstNameIgnoreCaseOrderByFirstNameAscLastNameAsc(firstName);
3232
}
3333
}

src/test/java/com/madadipouya/springkafkatest/kafka/repository/UserRepositoryTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,18 +26,18 @@ public class UserRepositoryTest {
2626

2727
@Test
2828
void testGetByFirstName() {
29-
testEntityManager.persist(stubUser("John", "Wick"));
29+
testEntityManager.persist(stubUser("john", "Wick"));
3030
testEntityManager.persist(stubUser("Robert", "McCall"));
3131
testEntityManager.persist(stubUser("John", "Rambo"));
3232

33-
List<User> users = userRepository.getByFirstName("John");
33+
List<User> users = userRepository.getByFirstNameIgnoreCaseOrderByFirstNameAscLastNameAsc("John");
3434

3535
assertFalse(users.isEmpty());
3636
assertEquals(2, users.size());
3737
assertEquals("John", users.get(0).getFirstName());
38-
assertEquals("Wick", users.get(0).getLastName());
39-
assertEquals("John", users.get(1).getFirstName());
40-
assertEquals("Rambo", users.get(1).getLastName());
38+
assertEquals("Rambo", users.get(0).getLastName());
39+
assertEquals("john", users.get(1).getFirstName());
40+
assertEquals("Wick", users.get(1).getLastName());
4141
}
4242

4343
private User stubUser(String firstName, String lastName) {
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
spring.jpa.show-sql=true
21
spring.datasource.url=jdbc:h2:file:~/testdb
32
spring.flyway.enabled=false

0 commit comments

Comments
 (0)