fix: improve file handling and error logging in linting process

Author: krema

lib/builder/src/builder.spec.ts

@@ -5,14 +5,14 @@ import { Architect } from '@angular-devkit/architect';
 import { TestingArchitectHost } from '@angular-devkit/architect/testing';
 import { logging, schema } from '@angular-devkit/core';
 import * as path from 'path';
+import * as fs from 'fs/promises';
 
 describe('Lint', () => {
   let architect: Architect;
   let architectHost: TestingArchitectHost;
   let logger: logging.Logger;
 
   beforeEach(async () => {
-    const fs = await import('fs/promises');
     await fs.copyFile('test/src/autofixable.ts.bak', 'test/src/autofixable.ts');
     await fs.copyFile('test/src/file.ts.bak', 'test/src/file.ts');
     await fs.copyFile('test/src/file.css.bak', 'test/src/file.css');
@@ -34,12 +34,12 @@ describe('Lint', () => {
   });
 
   afterEach(async () => {
-    const fs = await import('fs/promises');
     // Remove test files but keep the .bak files
     await Promise.all([
       fs.rm('test/src/autofixable.ts', { force: true }),
       fs.rm('test/src/file.ts', { force: true }),
       fs.rm('test/src/file.css', { force: true }),
+      fs.rm('test/lint-report.txt', { force: true }),
     ]);
   });
 
@@ -243,4 +243,39 @@ describe('Lint', () => {
     expect(output).not.toContain('file.ts');
     expect(output).not.toContain('file.css');
   });
+
+  it('writes JSON output to file with fix enabled', async () => {
+    const outputFile = 'lint-report.txt';
+
+    const run = await architect.scheduleBuilder(
+      '@krema/angular-eslint-stylelint-builder:lint',
+      {
+        eslintFilePatterns: ['src/**/*.ts'],
+        stylelintFilePatterns: ['src/**/*.css'],
+        fix: true,
+        outputFile,
+        format: 'json',
+        eslintConfig: 'eslint.config.js',
+        stylelintConfig: 'stylelint.config.js',
+      },
+      { logger }
+    );
+    await run.result;
+    await run.stop();
+    logger.complete();
+
+    // Check that the output file exists and contains valid JSON
+    let exists = false;
+    try {
+      await fs.access(path.join('test', outputFile));
+      exists = true;
+    } catch {
+      exists = false;
+    }
+    expect(exists).toBe(true);
+    if (exists) {
+      const content = await fs.readFile(path.join('test', outputFile), 'utf8');
+      expect(() => JSON.parse(content)).not.toThrow();
+    }
+  });
 });

lib/builder/src/eslint/reporter.ts

@@ -42,7 +42,11 @@ export async function report(
   if (options.outputFile) {
     const pathToOutputFile = join(workspaceRoot, options.outputFile);
     createDirectory(dirname(pathToOutputFile));
-    writeFileSync(pathToOutputFile, formattedResults);
+    try {
+      writeFileSync(pathToOutputFile, formattedResults || '');
+    } catch (err) {
+      context.logger.error(`[DEBUG] Failed to write output file: ${err}`);
+    }
   } else {
     context.logger.info(formattedResults);
   }

lib/builder/src/utils/create-directory.ts

@@ -3,11 +3,11 @@ import { mkdirSync, statSync } from 'fs';
 
 export function createDirectory(directoryPath: string): void {
   const parentPath = dirname(directoryPath);
-  if (!directoryExists(parentPath)) {
+  if (!directoryExists(parentPath) && parentPath !== directoryPath) {
     createDirectory(parentPath);
   }
   if (!directoryExists(directoryPath)) {
-    mkdirSync(directoryPath);
+    mkdirSync(directoryPath, { recursive: true });
   }
 }