fix: RCE

krissss · krissss · commit 5437cb3026bc · 2025-02-05T15:30:45.000+08:00
diff --git a/src/Traits/LogReaderControllerTrait.php b/src/Traits/LogReaderControllerTrait.php
@@ -54,7 +54,7 @@ public function tail()
     {
         $this->checkIsEnable();
         $file = $this->getPathFromRequest();
-        $line = $this->getRequest()->get('line', $this->getLogReader()->getTailDefaultLine());
+        $line = (int)$this->getRequest()->get('line', $this->getLogReader()->getTailDefaultLine());
         $result = shell_exec("tail -n {$line} {$file}");
 
         return new Response($result, 200, [

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public function tail()`
`54`	`54`	`{`
`55`	`55`	`$this->checkIsEnable();`
`56`	`56`	`$file = $this->getPathFromRequest();`
`57`		`- $line = $this->getRequest()->get('line', $this->getLogReader()->getTailDefaultLine());`
	`57`	`+ $line = (int)$this->getRequest()->get('line', $this->getLogReader()->getTailDefaultLine());`
`58`	`58`	`$result = shell_exec("tail -n {$line} {$file}");`
`59`	`59`
`60`	`60`	`return new Response($result, 200, [`