Issue with `vim_dadbod_completion#job#run` too many arguments

[brianle18]

Hi @kristijanhusak,

I'm trying to get this package working with nvim-cmp and vim-dadbod-ui for a postgresql server. I'm running into this bizarre error that seems to pop up when trying to retrieve the column names. Initially I thought it was something wrong with my configuration but I can confirm that the table names are being retrieved perfectly. I ended up trying to clear the cache and then found the same error with vim_dadbod_completion#job#run complaining of too many arguments.

I tried drilling into your source code and printing some messages and found this is the point it breaks for clearing the cache (probably something similar for the completion of the columns). Just did a basic printout to prove it doesn't reach the DONE printout.

I'm not familiar enough with vimscript to really tell what's going wrong here. As far as I can tell there's no way to give it too many arguments. Any help would be greatly appreciated, I would really like to get this up and running as I'd love to use a native nvim editor and ditch postico!

Best regards!

[kristijanhusak]

Hi,

This is really a strange issue. I'm using postgres on daily basis.
I'll need some more information/help around this.

1. How are you defining the connection? Through the vim-dadbod-ui?
2. If using vim-dadbod-ui, do you open up the buffer from the dadbod ui drawer?
3. Do you have full admin access to the database you are connecting to?
4. What system and vim/neovim version are you using?
5. Can you do the same message as the one on the screenshot, but use this:

    call vim_dadbod_completion#utils#msg('Here '.string(a:db).' '.string(ccq))

Give me the output of the message. Note that this will print DB connection url, so if it contains sensitive information, please mask them.

[brianle18]

No problem here are the answers to your questions:

1. Yes, running through vim-dadbod-ui
2. If you mean through the panel that opens up on the :DBUI command then yes
3. I have a production database where I'm using a read-only login and a dev one on my local. In my dev one I have full write access but in both cases I get the same issue
4. I'm using macOS Ventura and nvim v0.10.1
5. The output is

[dadbod completion] Here 'postgresql://*********' [['psql', '-w', '--dbname', 'postgresql://*********', '-A', '-c', 'SELECT COUNT(*) AS total
 FROM INFORMATION_SCHEMA.COLUMNS'], '']

for reference when I run that psql command I get a reasonable output

❯ psql -w --dbname postgresq://********* -A -c "SELECT COUNT(*) AS total FROM INFORMATION_SCHEMA.COLUMNS" 
total
3538

Hope this helps!

[brianle18]

Not a solution but removing the last argument of the #job#run calls (eg ccq[1]) seems to work. Clearing the cache now succeeds and I can confirm I can see column names in nvim-cmp.

Then I run into an issue when I try to autocomplete something like select alias_name.[TAB] from table as alias_name it comes up with

Taking this one issue at a time though, I don't understand the error message around too many arguments and I'm not sure if the hacky test I put together even makes sense. Hopefully it provides you with some more info @kristijanhusak.

[brianle18]

Hey just bumping this since it's been a couple of weeks

[kristijanhusak]

Hey, sorry, was sidetracked with other things. Will take a look at this today. Very strange issues.
Just to confirm, are you using the latest master branch of tpope/vim-dadbod ?

[brianle18]

Yes just updated lazy, still same issue. Commit is 96997da

[kristijanhusak]

The output from #82 (comment) looks same as mine, and looks fine. Issue is maybe somewhere deeper.

Can you apply this patch locally and give it a go? It should provide more information where the issue is:

diff --git a/autoload/vim_dadbod_completion.vim b/autoload/vim_dadbod_completion.vim
index 808ba6c..34f032f 100644
--- a/autoload/vim_dadbod_completion.vim
+++ b/autoload/vim_dadbod_completion.vim
@@ -281,10 +281,15 @@ function! s:generate_query(db, query_key, ...) abort
 endfunction
 
 function! s:count_columns_and_cache(db, count) abort
+  echom  'column count argument: '.string(a:count)
   let column_count = s:cache[a:db].scheme.count_parser(a:count)
+  echom 'parsed column count: '.string(column_count)
   if column_count <= 10000
     let [query, stdin] = s:generate_query(a:db, 'column_query')
+    echom 'Column query: '.string(query)
+    echom 'Column query stdin: '.string(stdin)
     call vim_dadbod_completion#job#run(query, function('s:cache_all_columns', [a:db]), stdin)
+    echom 'Column query ran'
   endif
 endfunction
 

[brianle18]

Same error as before

Doesn't seem to reach that function at all. It keeps complaining about this #job#run function

[kristijanhusak]

Ok, lets try this.
Discard the previous patch and apply this one:

diff --git a/autoload/vim_dadbod_completion/job.vim b/autoload/vim_dadbod_completion/job.vim
index 2e6f1cf..d0094fd 100644
--- a/autoload/vim_dadbod_completion/job.vim
+++ b/autoload/vim_dadbod_completion/job.vim
@@ -26,7 +26,9 @@ function! s:nvim_job_cb(jobid, data, event) dict abort
   call extend(self.output, a:data)
 endfunction
 
-function! vim_dadbod_completion#job#run(cmd, callback, stdin) abort
+function! vim_dadbod_completion#job#run(cmd, callback, ...) abort
+  echom 'JOB RUN CMD: '..string(a:cmd).' - args: '.string(a:000)
+  let stdin = a:0 > 0 ? a:1 : ''
   if has('nvim')
     let jobid = jobstart(a:cmd, {
           \ 'on_stdout': function('s:nvim_job_cb'),
@@ -38,8 +40,8 @@ function! vim_dadbod_completion#job#run(cmd, callback, stdin) abort
           \ 'stderr_buffered': 1,
           \ })
 
-    if !empty(a:stdin)
-      call chansend(jobid, a:stdin)
+    if !empty(stdin)
+      call chansend(jobid, stdin)
       call chanclose(jobid, 'stdin')
     endif
 
@@ -63,8 +65,8 @@ function! vim_dadbod_completion#job#run(cmd, callback, stdin) abort
 
     let job = job_start(a:cmd, opts)
 
-    if !empty(a:stdin)
-      call ch_sendraw(job, a:stdin)
+    if !empty(stdin)
+      call ch_sendraw(job, stdin)
       call ch_close_in(job)
       let fn.close = 1
     endif

This should now make it work for you. Once you run the clear completion cache command, give me the output of everything that you get. Just mask db if it's not the local one.

[kristijanhusak]

Did you manage to give above patch a try?
I cannot figure out the issue without your help since I cannot reproduce it. I'm really curious what can be the issue.

[brianle18]

Hi Kristijan,

Sorry it was a long weekend holiday here, it's giving the same complaint as before after applying the patch.

[kristijanhusak]

Ok, then this is the last thing we can try.

Apply this patch:

diff --git a/autoload/vim_dadbod_completion/job.vim b/autoload/vim_dadbod_completion/job.vim
index 2e6f1cf..3e80e08 100644
--- a/autoload/vim_dadbod_completion/job.vim
+++ b/autoload/vim_dadbod_completion/job.vim
@@ -26,20 +26,25 @@ function! s:nvim_job_cb(jobid, data, event) dict abort
   call extend(self.output, a:data)
 endfunction
 
-function! vim_dadbod_completion#job#run(cmd, callback, stdin) abort
+function! vim_dadbod_completion#job#run(...) abort
+  echom string(a:000)
+  let cmd = get(a:, 1)
+  let Callback = get(a:, 2)
+  let stdin = get(a:, 3)
+
   if has('nvim')
-    let jobid = jobstart(a:cmd, {
+    let jobid = jobstart(cmd, {
           \ 'on_stdout': function('s:nvim_job_cb'),
           \ 'on_stderr': function('s:nvim_job_cb'),
           \ 'on_exit': function('s:nvim_job_cb'),
           \ 'output': [],
-          \ 'callback': a:callback,
+          \ 'callback': Callback,
           \ 'stdout_buffered': 1,
           \ 'stderr_buffered': 1,
           \ })
 
-    if !empty(a:stdin)
-      call chansend(jobid, a:stdin)
+    if !empty(stdin)
+      call chansend(jobid, stdin)
       call chanclose(jobid, 'stdin')
     endif
 
@@ -48,7 +53,7 @@ function! vim_dadbod_completion#job#run(cmd, callback, stdin) abort
 
   if exists('*job_start')
     let fn = copy(s:vim_job)
-    let fn.callback = a:callback
+    let fn.callback = Callback
     let opts = {
           \ 'out_cb': fn.cb,
           \ 'err_cb': fn.cb,
@@ -61,10 +66,10 @@ function! vim_dadbod_completion#job#run(cmd, callback, stdin) abort
       let opts['noblock'] = 1
     endif
 
-    let job = job_start(a:cmd, opts)
+    let job = job_start(cmd, opts)
 
-    if !empty(a:stdin)
-      call ch_sendraw(job, a:stdin)
+    if !empty(stdin)
+      call ch_sendraw(job, stdin)
       call ch_close_in(job)
       let fn.close = 1
     endif

It will probably fail for you, but give me the output after you try to run it.

[brianle18]

It still fails with the exact same error and no printout from the function. It just doesn't seem to ever reach the vim_dadbod_completion#job#run function (or at least is never printing out).

[kristijanhusak]

Ok update that line with this:

    call vim_dadbod_completion#job#run(1, 2, 3)

And do :DBCompletionClearCache

Does it print [1, 2, 3] ?

[brianle18]

Do you mean like this:

Seems to have the same problem, it just doesn't reach that function it seems