-
Notifications
You must be signed in to change notification settings - Fork 850
Adding SnapshotLock Capabilities #2797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Code Coverage DiffThis PR does not change the code coverage |
|
/retest |
5a301d7 to
94ec03f
Compare
a809c40 to
744ab62
Compare
|
/hold Waiting on managed policy change. |
cb5430d to
53808c2
Compare
53808c2 to
f7a57e0
Compare
torredil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/kind feature
What is this PR about? / Why do we need it?
This PR adds the ability for users to lock snapshots on creation by passing in desired LockSnapshot parameters through the VolumeSnapshotClass.
How was this change tested?
Ran various unit tests as well as e2e tests that:
Also manually tested by running a modified version of our snapshot example.
examples/kubernetes/snapshotChangesnapshotclass.yamlto:Does this PR introduce a user-facing change?