Skip to content

Commit 2f550be

Browse files
committed
remove ununused value
1 parent 66fa78c commit 2f550be

File tree

3 files changed

+8
-22
lines changed

3 files changed

+8
-22
lines changed

pkg/deploy/elbv2/frontend_nlb_target_synthesizer.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ func (s *frontendNlbTargetSynthesizer) PostSynthesize(ctx context.Context) error
146146
})
147147

148148
if err != nil {
149-
s.logger.Error(err, "Got this error!")
150149
requeueMsg := "Failed to register target, retrying after deplay for target group: " + resTG.Status.TargetGroupARN
151150
return ctrlerrors.NewRequeueNeededAfter(requeueMsg, 15*time.Second)
152151
}

pkg/gateway/model/model_build_listener_test.go

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1317,11 +1317,8 @@ func Test_BuildListenerRules(t *testing.T) {
13171317
},
13181318
BackendRefs: []routeutils.Backend{
13191319
{
1320-
ServiceBackend: &routeutils.ServiceBackendConfig{
1321-
//Service: &corev1.Service{},
1322-
//ServicePort: &corev1.ServicePort{Name: "svcport"},
1323-
},
1324-
Weight: 1,
1320+
ServiceBackend: &routeutils.ServiceBackendConfig{},
1321+
Weight: 1,
13251322
},
13261323
},
13271324
},
@@ -1390,11 +1387,8 @@ func Test_BuildListenerRules(t *testing.T) {
13901387
},
13911388
BackendRefs: []routeutils.Backend{
13921389
{
1393-
ServiceBackend: &routeutils.ServiceBackendConfig{
1394-
//Service: &corev1.Service{},
1395-
//ServicePort: &corev1.ServicePort{Name: "svcport"},
1396-
},
1397-
Weight: 1,
1390+
ServiceBackend: &routeutils.ServiceBackendConfig{},
1391+
Weight: 1,
13981392
},
13991393
},
14001394
},
@@ -1450,11 +1444,8 @@ func Test_BuildListenerRules(t *testing.T) {
14501444
},
14511445
BackendRefs: []routeutils.Backend{
14521446
{
1453-
ServiceBackend: &routeutils.ServiceBackendConfig{
1454-
//Service: &corev1.Service{},
1455-
//ServicePort: &corev1.ServicePort{Name: "svcport"},
1456-
},
1457-
Weight: 1,
1447+
ServiceBackend: &routeutils.ServiceBackendConfig{},
1448+
Weight: 1,
14581449
},
14591450
},
14601451
ListenerRuleConfig: &elbv2gw.ListenerRuleConfiguration{
@@ -1525,11 +1516,8 @@ func Test_BuildListenerRules(t *testing.T) {
15251516
},
15261517
BackendRefs: []routeutils.Backend{
15271518
{
1528-
ServiceBackend: &routeutils.ServiceBackendConfig{
1529-
//Service: &corev1.Service{},
1530-
//ServicePort: &corev1.ServicePort{Name: "svcport"},
1531-
},
1532-
Weight: 1,
1519+
ServiceBackend: &routeutils.ServiceBackendConfig{},
1520+
Weight: 1,
15331521
},
15341522
},
15351523
ListenerRuleConfig: &elbv2gw.ListenerRuleConfiguration{

pkg/gateway/model/model_build_target_group_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1782,7 +1782,6 @@ func Test_buildTargetGroupFromGateway(t *testing.T) {
17821782
assert.True(t, exists)
17831783
assert.Equal(t, result.Spec.Name, frontendData.Name)
17841784
assert.Equal(t, tc.listenerPort, frontendData.Port)
1785-
//assert.Equal(t, tc.backendConfig.GetALBARN(), frontendData.TargetARN.Resolve(context.Background()))
17861785
assert.Equal(t, *result.Spec.Port, frontendData.TargetPort)
17871786
}
17881787
})

0 commit comments

Comments
 (0)