Skip to content

Commit e6ca090

Browse files
committed
add aga controller config flags
1 parent c98ba9e commit e6ca090

File tree

4 files changed

+22
-1
lines changed

4 files changed

+22
-1
lines changed

docs/deploy/configurations.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ Currently, you can set only 1 namespace to watch in this flag. See [this Kuberne
106106
| [sync-period](#sync-period) | duration | 10h0m0s | Period at which the controller forces the repopulation of its local object stores |
107107
| targetgroupbinding-max-concurrent-reconciles | int | 3 | Maximum number of concurrently running reconcile loops for targetGroupBinding |
108108
| targetgroupbinding-max-exponential-backoff-delay | duration | 16m40s | Maximum duration of exponential backoff for targetGroupBinding reconcile failures |
109+
| globalaccelerator-max-concurrent-reconciles | int | 1 | Maximum number of concurrently running reconcile loops for GlobalAccelerator objects |
110+
| globalaccelerator-max-exponential-backoff-delay | duration | 16m40s | Maximum duration of exponential backoff for GlobalAccelerator reconcile failures |
109111
| [lb-stabilization-monitor-interval](#lb-stabilization-monitor-interval) | duration | 2m | Interval at which the controller monitors the state of load balancer after creation
110112
| tolerate-non-existent-backend-service | boolean | true | Whether to allow rules which refer to backend services that do not exist (When enabled, it will return 503 error if backend service not exist) |
111113
| tolerate-non-existent-backend-action | boolean | true | Whether to allow rules which refer to backend actions that do not exist (When enabled, it will return 503 error if backend action not exist) |

helm/aws-load-balancer-controller/templates/deployment.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,12 @@ spec:
112112
{{- if .Values.targetgroupbindingMaxExponentialBackoffDelay }}
113113
- --targetgroupbinding-max-exponential-backoff-delay={{ .Values.targetgroupbindingMaxExponentialBackoffDelay }}
114114
{{- end }}
115+
{{- if .Values.globalAcceleratorMaxConcurrentReconciles }}
116+
- --globalaccelerator-max-concurrent-reconciles={{ .Values.globalAcceleratorMaxConcurrentReconciles }}
117+
{{- end }}
118+
{{- if .Values.globalAcceleratorMaxExponentialBackoffDelay }}
119+
- --globalaccelerator-max-exponential-backoff-delay={{ .Values.globalAcceleratorMaxExponentialBackoffDelay }}
120+
{{- end }}
115121
{{- if .Values.lbStabilizationMonitorInterval }}
116122
- --lb-stabilization-monitor-interval={{ .Values.lbStabilizationMonitorInterval }}
117123
{{- end }}

helm/aws-load-balancer-controller/values.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,12 @@ targetgroupbindingMaxConcurrentReconciles:
253253
# Maximum duration of exponential backoff for targetGroupBinding reconcile failures
254254
targetgroupbindingMaxExponentialBackoffDelay:
255255

256+
# Maximum number of concurrently running reconcile loops for GlobalAccelerator objects
257+
globalAcceleratorMaxConcurrentReconciles:
258+
259+
# Maximum duration of exponential backoff for GlobalAccelerator reconcile failures
260+
globalAcceleratorMaxExponentialBackoffDelay:
261+
256262
# Interval at which the controller monitors the state of load balancer after creation for stabilization
257263
lbStabilizationMonitorInterval:
258264

pkg/config/controller_config.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ const (
2727
flagALBGatewayMaxConcurrentReconciles = "alb-gateway-max-concurrent-reconciles"
2828
flagNLBGatewayMaxConcurrentReconciles = "nlb-gateway-max-concurrent-reconciles"
2929
flagGlobalAcceleratorMaxConcurrentReconciles = "globalaccelerator-max-concurrent-reconciles"
30+
flagGlobalAcceleratorMaxExponentialBackoffDelay = "globalaccelerator-max-exponential-backoff-delay"
3031
flagTargetGroupBindingMaxExponentialBackoffDelay = "targetgroupbinding-max-exponential-backoff-delay"
3132
flagLbStabilizationMonitorInterval = "lb-stabilization-monitor-interval"
3233
flagDefaultSSLPolicy = "default-ssl-policy"
@@ -37,6 +38,7 @@ const (
3738
flagDisableRestrictedSGRules = "disable-restricted-sg-rules"
3839
flagMaxTargetsPerTargetGroup = "max-targets-per-target-group"
3940
defaultLogLevel = "info"
41+
defaultGlobalAcceleratorMaxConcurrentReconciles = 1
4042
defaultMaxConcurrentReconciles = 3
4143
defaultMaxExponentialBackoffDelay = time.Second * 1000
4244
defaultSSLPolicy = "ELBSecurityPolicy-2016-08"
@@ -123,6 +125,9 @@ type ControllerConfig struct {
123125
// GlobalAcceleratorMaxConcurrentReconciles Max concurrent reconcile loops for GlobalAccelerator objects
124126
GlobalAcceleratorMaxConcurrentReconciles int
125127

128+
// GlobalAcceleratorMaxExponentialBackoffDelay Max exponential backoff delay for reconcile failures of GlobalAccelerator
129+
GlobalAcceleratorMaxExponentialBackoffDelay time.Duration
130+
126131
// EnableBackendSecurityGroup specifies whether to use optimized security group rules
127132
EnableBackendSecurityGroup bool
128133

@@ -168,8 +173,10 @@ func (cfg *ControllerConfig) BindFlags(fs *pflag.FlagSet) {
168173
"Maximum number of concurrently running reconcile loops for alb gateway")
169174
fs.IntVar(&cfg.NLBGatewayMaxConcurrentReconciles, flagNLBGatewayMaxConcurrentReconciles, defaultMaxConcurrentReconciles,
170175
"Maximum number of concurrently running reconcile loops for nlb gateway")
171-
fs.IntVar(&cfg.GlobalAcceleratorMaxConcurrentReconciles, flagGlobalAcceleratorMaxConcurrentReconciles, defaultMaxConcurrentReconciles,
176+
fs.IntVar(&cfg.GlobalAcceleratorMaxConcurrentReconciles, flagGlobalAcceleratorMaxConcurrentReconciles, defaultGlobalAcceleratorMaxConcurrentReconciles,
172177
"Maximum number of concurrently running reconcile loops for globalAccelerator")
178+
fs.DurationVar(&cfg.GlobalAcceleratorMaxExponentialBackoffDelay, flagGlobalAcceleratorMaxExponentialBackoffDelay, defaultMaxExponentialBackoffDelay,
179+
"Maximum duration of exponential backoff for globalAccelerator reconcile failures")
173180
fs.DurationVar(&cfg.TargetGroupBindingMaxExponentialBackoffDelay, flagTargetGroupBindingMaxExponentialBackoffDelay, defaultMaxExponentialBackoffDelay,
174181
"Maximum duration of exponential backoff for targetGroupBinding reconcile failures")
175182
fs.DurationVar(&cfg.LBStabilizationMonitorInterval, flagLbStabilizationMonitorInterval, defaultLbStabilizationMonitorInterval,

0 commit comments

Comments
 (0)