Skip to content

[gw api] Implement ALB target of NLB #4430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 6, 2025
Merged

[gw api] Implement ALB target of NLB #4430

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
50b997a
remove unused parameters
zac-nixon Oct 31, 2025
0819b45
refactor service interactions into its own struct
zac-nixon Oct 31, 2025
8fb9a04
refactor front nlb data passing to deployer
zac-nixon Oct 31, 2025
9bd4c27
working alb as target of nlb in gateway api
zac-nixon Nov 3, 2025
2f442de
fix enum check, the casing was incorrect
zac-nixon Nov 4, 2025
76da6d4
add validation to ensure it is really an ALB gateway
zac-nixon Nov 4, 2025
819879e
handle tg config updates for gateway based backends
zac-nixon Nov 4, 2025
66fa78c
add e2e test for gateway api alb target of nlb
zac-nixon Nov 4, 2025
2f550be
remove ununused value
zac-nixon Nov 4, 2025
5599bda
review fixes
zac-nixon Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/deploy/elbv2/frontend_nlb_target_synthesizer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ func (s *frontendNlbTargetSynthesizer) PostSynthesize(ctx context.Context) error
})

if err != nil {
s.logger.Error(err, "Got this error!")
Copy link
Collaborator

@shraddhabang shraddhabang Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we log debug error for troubleshooting to know the exact error?

Copy link
Collaborator Author

@zac-nixon zac-nixon Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because it's an expected error message (when the ALB is still being provisioned)

requeueMsg := "Failed to register target, retrying after deplay for target group: " + resTG.Status.TargetGroupARN
return ctrlerrors.NewRequeueNeededAfter(requeueMsg, 15*time.Second)
}
Expand Down
28 changes: 8 additions & 20 deletions pkg/gateway/model/model_build_listener_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1317,11 +1317,8 @@ func Test_BuildListenerRules(t *testing.T) {
},
BackendRefs: []routeutils.Backend{
{
ServiceBackend: &routeutils.ServiceBackendConfig{
//Service: &corev1.Service{},
//ServicePort: &corev1.ServicePort{Name: "svcport"},
},
Weight: 1,
ServiceBackend: &routeutils.ServiceBackendConfig{},
Weight: 1,
},
},
},
Expand Down Expand Up @@ -1390,11 +1387,8 @@ func Test_BuildListenerRules(t *testing.T) {
},
BackendRefs: []routeutils.Backend{
{
ServiceBackend: &routeutils.ServiceBackendConfig{
//Service: &corev1.Service{},
//ServicePort: &corev1.ServicePort{Name: "svcport"},
},
Weight: 1,
ServiceBackend: &routeutils.ServiceBackendConfig{},
Weight: 1,
},
},
},
Expand Down Expand Up @@ -1450,11 +1444,8 @@ func Test_BuildListenerRules(t *testing.T) {
},
BackendRefs: []routeutils.Backend{
{
ServiceBackend: &routeutils.ServiceBackendConfig{
//Service: &corev1.Service{},
//ServicePort: &corev1.ServicePort{Name: "svcport"},
},
Weight: 1,
ServiceBackend: &routeutils.ServiceBackendConfig{},
Weight: 1,
},
},
ListenerRuleConfig: &elbv2gw.ListenerRuleConfiguration{
Expand Down Expand Up @@ -1525,11 +1516,8 @@ func Test_BuildListenerRules(t *testing.T) {
},
BackendRefs: []routeutils.Backend{
{
ServiceBackend: &routeutils.ServiceBackendConfig{
//Service: &corev1.Service{},
//ServicePort: &corev1.ServicePort{Name: "svcport"},
},
Weight: 1,
ServiceBackend: &routeutils.ServiceBackendConfig{},
Weight: 1,
},
},
ListenerRuleConfig: &elbv2gw.ListenerRuleConfiguration{
Expand Down
1 change: 0 additions & 1 deletion pkg/gateway/model/model_build_target_group_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1782,7 +1782,6 @@ func Test_buildTargetGroupFromGateway(t *testing.T) {
assert.True(t, exists)
assert.Equal(t, result.Spec.Name, frontendData.Name)
assert.Equal(t, tc.listenerPort, frontendData.Port)
//assert.Equal(t, tc.backendConfig.GetALBARN(), frontendData.TargetARN.Resolve(context.Background()))
assert.Equal(t, *result.Spec.Port, frontendData.TargetPort)
}
})
Expand Down
Loading