-
Notifications
You must be signed in to change notification settings - Fork 306
✨ Add supports to Crypto Spec in VMOp VirtualMachine and PVC #3680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d044a65 to
e10f947
Compare
84c63df to
6a0a4f2
Compare
zjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM
6a0a4f2 to
e99c305
Compare
e99c305 to
ce9801b
Compare
zhanggbj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Overall LGTM, just left some nits.
|
|
||
| // The version of vm-operator should be kept in sync with the manifests at: config/deployments/integration-tests | ||
| replace github.com/vmware-tanzu/vm-operator/api => github.com/vmware-tanzu/vm-operator/api v1.8.6 | ||
| replace github.com/vmware-tanzu/vm-operator/api => github.com/vmware-tanzu/vm-operator/api v1.9.1-0.20251029150609-93918c59a719 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Encryption Class is backported to VMOP API later than VM AF/AAF, will update PR #3655 to use this commit.
Also CC @fabriziopandini @sbueringer for awareness.
|
LGTM label has been added. Git tree hash: 82929e1a102a4d6b7974fbb89c7bc5dccfae8393
|
|
New changes are detected. LGTM label has been removed. |
c647abd to
4df5cf4
Compare
silvery1622
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments regarding the validation rules for VirtualMachineCryptoSpec and the existence validation for EncryptionClass.
What this PR does / why we need it:
Add new fields to opt-in
EncryptionClassname on volumesand
VMOp.CryptoVirtualMachineCryptoSpec.CryptoNote: The
EncryptionClassNamechanged to use *string because of the API lint in CAPV.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #