Skip to content

Commit 176601e

Browse files
authored
update inferencepool helm chart flags to be map instead of an array (#1818)
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
1 parent fcdddaa commit 176601e

File tree

3 files changed

+27
-7
lines changed

3 files changed

+27
-7
lines changed

config/charts/inferencepool/README.md

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,28 @@ $ helm install vllm-llama3-8b-instruct \
2222

2323
Note that the provider name is needed to deploy provider-specific resources. If no provider is specified, then only the InferencePool object and the EPP are deployed.
2424

25+
### Install with Custom Cmd-line Flags
26+
27+
To set cmd-line flags, you can use the `--set` option to set each flag, e.g.,:
28+
29+
```txt
30+
$ helm install vllm-llama3-8b-instruct \
31+
--set inferencePool.modelServers.matchLabels.app=vllm-llama3-8b-instruct \
32+
--set inferenceExtension.flags.<FLAG_NAME>=<FLAG_VALUE>
33+
--set provider.name=[none|gke|istio] \
34+
oci://us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/charts/inferencepool --version v0
35+
```
36+
37+
Alternatively, you can define flags in the `values.yaml` file:
38+
39+
```yaml
40+
inferenceExtension:
41+
flags:
42+
FLAG_NAME: <FLAG_VALUE>
43+
v: 3 ## Log verbosity
44+
...
45+
```
46+
2547
### Install with Custom Environment Variables
2648

2749
To set custom environment variables for the EndpointPicker deployment, you can define them as free-form YAML in the `values.yaml` file:
@@ -182,7 +204,7 @@ The following table list the configurable parameters of the chart.
182204
| `inferenceExtension.env` | List of environment variables to set in the endpoint picker container as free-form YAML. Defaults to `[]`. |
183205
| `inferenceExtension.extraContainerPorts` | List of additional container ports to expose. Defaults to `[]`. |
184206
| `inferenceExtension.extraServicePorts` | List of additional service ports to expose. Defaults to `[]`. |
185-
| `inferenceExtension.flags` | List of flags which are passed through to endpoint picker. Example flags, enable-pprof, grpc-port etc. Refer [runner.go](https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/cmd/epp/runner/runner.go) for complete list. |
207+
| `inferenceExtension.flags` | map of flags which are passed through to endpoint picker. Example flags, enable-pprof, grpc-port etc. Refer [runner.go](https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/main/cmd/epp/runner/runner.go) for complete list. |
186208
| `inferenceExtension.affinity` | Affinity for the endpoint picker. Defaults to `{}`. |
187209
| `inferenceExtension.tolerations` | Tolerations for the endpoint picker. Defaults to `[]`. |
188210
| `inferenceExtension.monitoring.interval` | Metrics scraping interval for monitoring. Defaults to `10s`. |

config/charts/inferencepool/templates/epp-deployment.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ spec:
5858
- --ha-enable-leader-election
5959
{{- end }}
6060
# Pass additional flags via the inferenceExtension.flags field in values.yaml.
61-
{{- range .Values.inferenceExtension.flags }}
62-
- "--{{ .name }}"
63-
- "{{ .value }}"
61+
{{- range $key, $value := .Values.inferenceExtension.flags }}
62+
- --{{ $key }}
63+
- {{ $value }}
6464
{{- end }}
6565
{{- if .Values.inferenceExtension.tracing.enabled }}
6666
- --tracing=true
@@ -103,7 +103,6 @@ spec:
103103
service: inference-extension
104104
{{- end }}
105105
periodSeconds: 2
106-
107106
env:
108107
- name: NAMESPACE
109108
valueFrom:

config/charts/inferencepool/values.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ inferenceExtension:
3333

3434
flags:
3535
# Log verbosity
36-
- name: v
37-
value: 1
36+
v: 1
3837

3938
affinity: {}
4039

0 commit comments

Comments
 (0)